From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbdDCXCC (ORCPT ); Mon, 3 Apr 2017 19:02:02 -0400 Received: from mail-pg0-f43.google.com ([74.125.83.43]:34634 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbdDCXCA (ORCPT ); Mon, 3 Apr 2017 19:02:00 -0400 Date: Mon, 3 Apr 2017 16:01:58 -0700 From: Matthias Kaehlcke To: hpa@zytor.com Cc: Michael Davidson , Michal Marek , Thomas Gleixner , Ingo Molnar , Herbert Xu , "David S. Miller" , Shaohua Li , Alexander Potapenko , Dmitry Vyukov , x86@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 3/7] x86, LLVM: suppress clang warnings about unaligned accesses Message-ID: <20170403230158.GA145051@google.com> References: <20170317001520.85223-1-md@google.com> <20170317001520.85223-4-md@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El Fri, Mar 17, 2017 at 04:50:19PM -0700 hpa@zytor.com ha dit: > On March 16, 2017 5:15:16 PM PDT, Michael Davidson wrote: > >Suppress clang warnings about potential unaliged accesses > >to members in packed structs. This gets rid of almost 10,000 > >warnings about accesses to the ring 0 stack pointer in the TSS. > > > >Signed-off-by: Michael Davidson > >--- > > arch/x86/Makefile | 5 +++++ > > 1 file changed, 5 insertions(+) > > > >diff --git a/arch/x86/Makefile b/arch/x86/Makefile > >index 894a8d18bf97..7f21703c475d 100644 > >--- a/arch/x86/Makefile > >+++ b/arch/x86/Makefile > >@@ -128,6 +128,11 @@ endif > > KBUILD_CFLAGS += $(call cc-option,-maccumulate-outgoing-args) > > endif > > > >+ifeq ($(cc-name),clang) > >+# Suppress clang warnings about potential unaligned accesses. > >+KBUILD_CFLAGS += $(call cc-disable-warning, address-of-packed-member) > >+endif > >+ > > ifdef CONFIG_X86_X32 > > x32_ld_ok := $(call try-run,\ > > /bin/echo -e '1: .quad 1b' | \ > > Why conditional on clang? My understanding is that this warning is clang specific, it is not listed on https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html Cheers Matthias