From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754020AbdDDMaG (ORCPT ); Tue, 4 Apr 2017 08:30:06 -0400 Received: from foss.arm.com ([217.140.101.70]:43870 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753016AbdDDMaF (ORCPT ); Tue, 4 Apr 2017 08:30:05 -0400 Date: Tue, 4 Apr 2017 13:29:43 +0100 From: Mark Rutland To: Ganapatrao Kulkarni Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com, catalin.marinas@arm.com, acme@kernel.org, alexander.shishkin@linux.intel.com, peterz@infradead.org, mingo@redhat.com, jnair@caviumnetworks.com, gpkulkarni@gmail.com Subject: Re: [PATCH 0/3] Add support for ThunderX2 pmu events using json files Message-ID: <20170404122943.GC8551@leverpostej> References: <1491291403-29893-1-git-send-email-ganapatrao.kulkarni@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491291403-29893-1-git-send-email-ganapatrao.kulkarni@cavium.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Apr 04, 2017 at 01:06:40PM +0530, Ganapatrao Kulkarni wrote: > Extending json/jevent framework for parsing arm64 event files. > Adding jevents for ThunderX2 implementation defined PMU events. Thanks for having a look at this! While I agree this is the right approach generally, I have a couple of issues with the implementation, which I have commented upon in subsequent patches. Thanks, Mark. > Ganapatrao Kulkarni (3): > perf jevents: Add support to use core pmu name other than cpu > perf tools arm64: implement function get_cpuid_str > perf tool, arm64, thunderx2: Add implementation defined events for > thunderx2 > > tools/perf/arch/arm64/util/Build | 1 + > tools/perf/arch/arm64/util/header.c | 51 +++++++++++++++ > tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 + > .../arm64/thunderx2/implementation-defined.json | 72 ++++++++++++++++++++++ > tools/perf/pmu-events/jevents.c | 15 +++-- > tools/perf/pmu-events/jevents.h | 3 +- > tools/perf/pmu-events/pmu-events.h | 1 + > tools/perf/util/pmu.c | 2 +- > 8 files changed, 140 insertions(+), 7 deletions(-) > create mode 100644 tools/perf/arch/arm64/util/header.c > create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv > create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json > > -- > 1.8.1.4 >