linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fs: compat: Remove warning from COMPATIBLE_IOCTL
@ 2017-04-04 18:07 Matthias Kaehlcke
  2017-04-19 18:14 ` Matthias Kaehlcke
  0 siblings, 1 reply; 6+ messages in thread
From: Matthias Kaehlcke @ 2017-04-04 18:07 UTC (permalink / raw)
  To: Alexander Viro, Mark Charlebois, Behan Webster, Arnd Bergmann
  Cc: linux-kernel, linux-fsdevel, Grant Grundler, Michael Davidson,
	Greg Hackmann, Peter Foley, Matthias Kaehlcke

From: Mark Charlebois <charlebm@gmail.com>

cmd in COMPATIBLE_IOCTL is always a u32, so cast it so there isn't a
warning about an overflow in XFORM.

From: Mark Charlebois <charlebm@gmail.com>
Signed-off-by: Mark Charlebois <charlebm@gmail.com>
Signed-off-by: Behan Webster <behanw@converseincode.com>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
Resending https://patchwork.kernel.org/patch/4961631/

 fs/compat_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index 11d087b2b28e..6116d5275a3e 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -833,7 +833,7 @@ static int compat_ioctl_preallocate(struct file *file,
  */
 #define XFORM(i) (((i) ^ ((i) << 27) ^ ((i) << 17)) & 0xffffffff)
 
-#define COMPATIBLE_IOCTL(cmd) XFORM(cmd),
+#define COMPATIBLE_IOCTL(cmd) XFORM((u32)cmd),
 /* ioctl should not be warned about even if it's not implemented.
    Valid reasons to use this:
    - It is implemented with ->compat_ioctl on some device, but programs
-- 
2.12.2.715.g7642488e1d-goog

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-04-20 19:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 18:07 [PATCH] fs: compat: Remove warning from COMPATIBLE_IOCTL Matthias Kaehlcke
2017-04-19 18:14 ` Matthias Kaehlcke
2017-04-19 20:48   ` Arnd Bergmann
2017-04-19 21:37     ` Matthias Kaehlcke
2017-04-20  8:45       ` Arnd Bergmann
2017-04-20 19:56         ` Matthias Kaehlcke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).