From: Thierry Reding <thierry.reding@gmail.com>
To: Yang Ling <gnaygnil@gmail.com>
Cc: Marcin Nowakowski <marcin.nowakowski@imgtec.com>,
Keguang Zhang <keguang.zhang@gmail.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH v2 1/2] pwm: loongson1: Add PWM driver for Loongson1 SoC
Date: Thu, 6 Apr 2017 18:18:35 +0200 [thread overview]
Message-ID: <20170406161835.GA19312@ulmo.ba.sec> (raw)
In-Reply-To: <20170215144531.GA39000@ubuntu>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Wed, Feb 15, 2017 at 10:45:31PM +0800, Yang Ling wrote:
> Add support for the PWM controller present in Loongson1 family of SoCs.
>
> Signed-off-by: Yang Ling <gnaygnil@gmail.com>
>
> ---
> V2:
> Remove ls1x_pwm_channel.
> Remove period_ns/duty_ns check.
> Add return values check.
> ---
> drivers/pwm/Kconfig | 9 +++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-loongson1.c | 148 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 158 insertions(+)
> create mode 100644 drivers/pwm/pwm-loongson1.c
Looks like this doesn't compile because it uses register definitions
from loongson1.h that aren't what the driver expects. Looks like the
driver wants parameterized ones, but those present in the kernel are
not.
Any plans on fixing that? How did you build-test this?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-06 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 14:45 [PATCH v2 1/2] pwm: loongson1: Add PWM driver for Loongson1 SoC Yang Ling
2017-04-06 16:18 ` Thierry Reding [this message]
2017-04-24 12:55 ` Yang Ling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406161835.GA19312@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=gnaygnil@gmail.com \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marcin.nowakowski@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).