From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Borislav Petkov <bp@alien8.de>
Cc: Wei Yang <richard.weiyang@gmail.com>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()
Date: Thu, 6 Apr 2017 21:21:47 +0300 [thread overview]
Message-ID: <20170406182147.mwifrukq7ylczi6i@node.shutemov.name> (raw)
In-Reply-To: <20170406180113.hvcydzrjldodosfo@pd.tnic>
On Thu, Apr 06, 2017 at 08:01:13PM +0200, Borislav Petkov wrote:
> On Thu, Apr 06, 2017 at 06:42:16PM +0300, Kirill A. Shutemov wrote:
> > Config is attached.
>
> Thanks!
>
> > Looks like fake numa is the key.
>
> ...
>
> > NUMA: Warning: node ids are out of bound, from=0 to=1 distance=20 [ 0.000000] numa_register_memblks: numa_nodes_parsed: 0
> > numa_register_memblks: nid: 0
> > numa_register_memblks: nid: 1
> > numa_register_memblks: nid: 2
> > numa_register_memblks: nid: 3
>
> Yeah, the fake numa thing calls emu_setup_memblk() and that doesn't
> set numa_nodes_parsed to the number of fake numa nodes. And since with
> that "cleanup" which opened more work than it saved (btw, this is the
> last time I'm looking at crap like that) we got rid of the "enlarging"
> of the node mask to the actual nodes count and *that* blows up with
> numa_nodes_parsed having only node 0 in there.
>
> Long story short, something as trivial as this helps here:
Yep. Works for me.
Reported-and-tested-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2017-04-06 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 3:08 [Patch V2 1/2] x86/mm/numa: trivial fix on typo and error message Wei Yang
2017-03-14 3:08 ` [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo() Wei Yang
2017-04-03 9:58 ` [tip:x86/mm] x86/mm/numa: Remove numa_nodemask_from_meminfo() tip-bot for Wei Yang
2017-04-06 12:44 ` [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo() Kirill A. Shutemov
2017-04-06 14:59 ` Borislav Petkov
2017-04-06 15:42 ` Kirill A. Shutemov
2017-04-06 18:01 ` Borislav Petkov
2017-04-06 18:21 ` Kirill A. Shutemov [this message]
2017-04-06 18:48 ` Borislav Petkov
2017-04-09 3:12 ` Wei Yang
2017-04-10 12:43 ` Borislav Petkov
2017-04-10 16:39 ` Wei Yang
2017-04-03 9:57 ` [tip:x86/mm] x86/mm/numa: Improve alloc_node_data() error path message tip-bot for Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406182147.mwifrukq7ylczi6i@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).