From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754743AbdDFVXB (ORCPT ); Thu, 6 Apr 2017 17:23:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56632 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbdDFVWv (ORCPT ); Thu, 6 Apr 2017 17:22:51 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EB8C0335EAC Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jglisse@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EB8C0335EAC Date: Thu, 6 Apr 2017 17:22:47 -0400 From: Jerome Glisse To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: John Hubbard , Dan Williams , Naoya Horiguchi , David Nellans , Evgeny Baskakov , Mark Hairgrove , Sherry Cheung , Subhash Gutti Subject: Re: [HMM 14/16] mm/hmm/devmem: device memory hotplug using ZONE_DEVICE Message-ID: <20170406212247.GA4723@redhat.com> References: <20170405204026.3940-1-jglisse@redhat.com> <20170405204026.3940-15-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170405204026.3940-15-jglisse@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 06 Apr 2017 21:22:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit So during rebase on lastest mmotm one if branch logic got inversed. Attached is a fixup patch. Cheers, Jérôme --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-fixup-mm-hmm-devmem-device-memory-hotplug-using-ZONE.patch" >>From 374bca39b19a88da1d1c6d38c0a4c49c1af31c18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= Date: Thu, 6 Apr 2017 17:16:56 -0400 Subject: [PATCH] fixup! mm/hmm/devmem: device memory hotplug using ZONE_DEVICE --- mm/hmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hmm.c b/mm/hmm.c index ff8ec59..f567a8b 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -898,7 +898,7 @@ static int hmm_devmem_pages_create(struct hmm_devmem *devmem) ret = arch_add_memory(nid, align_start, align_size, devmem->pagemap.type); mem_hotplug_done(); - if (!ret) + if (ret) goto error_add_memory; for (pfn = devmem->pfn_first; pfn < devmem->pfn_last; pfn++) { -- 2.9.3 --ZPt4rx8FFjLCG7dd--