From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756646AbdDGO2D (ORCPT ); Fri, 7 Apr 2017 10:28:03 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:54568 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755992AbdDGO1y (ORCPT ); Fri, 7 Apr 2017 10:27:54 -0400 Date: Fri, 07 Apr 2017 07:27:52 -0700 (PDT) Message-Id: <20170407.072752.496227480340210620.davem@davemloft.net> To: andrew@lunn.ch Cc: jbe@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, kernel@pengutronix.de, vivien.didelot@savoirfairelinux.com Subject: Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support From: David Miller In-Reply-To: <20170407141925.GB23415@lunn.ch> References: <20170407081502.30172-1-jbe@pengutronix.de> <20170407081502.30172-5-jbe@pengutronix.de> <20170407141925.GB23415@lunn.ch> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 07 Apr 2017 06:46:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Lunn Date: Fri, 7 Apr 2017 16:19:25 +0200 >> +static const struct of_device_id lan9303_mdio_of_match[] = { >> + { .compatible = "smsc,lan9303" }, >> + { /* sentinel */ }, >> +}; > > We still have the open question of is it a problem to have two > different drivers using the same compatible string. Changing these > strings is hard, once they are in use, so i would prefer to get this > answered before the code is accepted. Agreed.