From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756586AbdDGOWj (ORCPT ); Fri, 7 Apr 2017 10:22:39 -0400 Received: from mail.kernel.org ([198.145.29.136]:37766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756554AbdDGOWa (ORCPT ); Fri, 7 Apr 2017 10:22:30 -0400 Date: Fri, 7 Apr 2017 10:22:25 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Andrew Morton , "Paul E. McKenney" Subject: Re: [PATCH 3/5 v2] tracing: Add stack_tracer_disable/enable() functions Message-ID: <20170407102225.6180f0ed@gandalf.local.home> In-Reply-To: <20170407140308.625943712@goodmis.org> References: <20170407140106.051135969@goodmis.org> <20170407140308.625943712@goodmis.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 07 Apr 2017 10:01:09 -0400 Steven Rostedt wrote: > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index ef7123219f14..40afee35565a 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -286,6 +286,12 @@ int > stack_trace_sysctl(struct ctl_table *table, int write, > void __user *buffer, size_t *lenp, > loff_t *ppos); > + > +void stack_tracer_disable(void); > +void stack_tracer_enable(void); > +#else > +static inline void stack_tracer_disable(void) { } > +static inline void stack_tracer_enabe(void) { } Grumble. kbot caught that this is enabe not enable. I cut and pasted the bad name to all places, and when I compiled, it complained. I fixed the ones to make my system build, but forgot to fix the #ifndef version :-( I'll fix this before pushing. -- Steve