From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934594AbdDGR2x (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Apr 2017 13:28:53 -0400
Received: from mail.kernel.org ([198.145.29.136]:43576 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934572AbdDGR2b (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Apr 2017 13:28:31 -0400
Date: Fri, 7 Apr 2017 13:28:27 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH 7/5] tracing: Make sure rcu_irq_enter() can work for
 trace_*_rcuidle() trace events
Message-ID: <20170407132827.32300d5e@gandalf.local.home>
In-Reply-To: <1475342880.4473.1491585545139.JavaMail.zimbra@efficios.com>
References: <20170407140106.051135969@goodmis.org>
        <20170407130615.2309b96d@gandalf.local.home>
        <1475342880.4473.1491585545139.JavaMail.zimbra@efficios.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> > use rcu_irq_enter() it must make sure that it is functionable. A check  
> 
> I don't think functionable is the word you are looking for here. Perhaps
> "must make sure that it can be invoked" ?

Well, rcu_irq_enter() doesn't function in that location. And it's a
change log, not in the code. I think it gets the point across enough.

-- Steve