From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756134AbdDGNlc (ORCPT ); Fri, 7 Apr 2017 09:41:32 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:49643 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755886AbdDGNkL (ORCPT ); Fri, 7 Apr 2017 09:40:11 -0400 Date: Fri, 7 Apr 2017 15:40:07 +0200 From: Andrew Lunn To: Juergen Borleis Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, kernel@pengutronix.de, vivien.didelot@savoirfairelinux.com, davem@davemloft.net Subject: Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Message-ID: <20170407134007.GA22263@lunn.ch> References: <20170407081502.30172-1-jbe@pengutronix.de> <20170407081502.30172-4-jbe@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170407081502.30172-4-jbe@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Juergen > +Optional properties: > + > +- reset-gpios: GPIO to be used to reset the whole device, always low active I would avoid the always low active comment. The input to the switch is active low. But i've seen designs with an inverter in the reset path, so from the perspective of the GPIO it would be active high. The device tree binding allows for this, via the flags. And since you use the gpiod API, it should all just work. > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { /* RMII fixed link to master */ > + reg = <0>; > + label = "cpu"; > + ethernet = <&master>; > + }; > + > + port@1 { /* external port 1 */ > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + label = "lan1; > + }; These are not PHY nodes, so does this compatible string do anything? Andrew