From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756286AbdDGNn0 (ORCPT ); Fri, 7 Apr 2017 09:43:26 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:33360 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755901AbdDGNly (ORCPT ); Fri, 7 Apr 2017 09:41:54 -0400 Date: Fri, 7 Apr 2017 15:41:49 +0200 From: Daniel Lezcano To: Linus Walleij Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, robh@kernel.org Subject: Re: [PATCH 1/3] clocksource: Augment bindings for Faraday timer Message-ID: <20170407134149.GJ2078@mai> References: <20170324213235.16119-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170324213235.16119-1-linus.walleij@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2017 at 10:32:33PM +0100, Linus Walleij wrote: > It turns out that the Cortina Gemini timer block is just a > standard IP block from Faraday Technology named FTTMR010. > > In order to make things clear and understandable, we rename the > bindings with a Faraday compatible as primary and the Cortina > gemini as a more specific case. > > For the plain Faraday timer we require two clock references, > while the Gemini can keep it's syscon lookup pattern. > > Signed-off-by: Linus Walleij > --- Rob ? Is this change ok for you? Thanks. -- Daniel > .../bindings/timer/cortina,gemini-timer.txt | 22 --------------- > .../devicetree/bindings/timer/faraday,fttmr010.txt | 33 ++++++++++++++++++++++ > 2 files changed, 33 insertions(+), 22 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt > create mode 100644 Documentation/devicetree/bindings/timer/faraday,fttmr010.txt > > diff --git a/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt b/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt > deleted file mode 100644 > index 16ea1d3b2e9e..000000000000 > --- a/Documentation/devicetree/bindings/timer/cortina,gemini-timer.txt > +++ /dev/null > @@ -1,22 +0,0 @@ > -Cortina Systems Gemini timer > - > -This timer is embedded in the Cortina Systems Gemini SoCs. > - > -Required properties: > - > -- compatible : Must be "cortina,gemini-timer" > -- reg : Should contain registers location and length > -- interrupts : Should contain the three timer interrupts with > - flags for rising edge > -- syscon : a phandle to the global Gemini system controller > - > -Example: > - > -timer@43000000 { > - compatible = "cortina,gemini-timer"; > - reg = <0x43000000 0x1000>; > - interrupts = <14 IRQ_TYPE_EDGE_RISING>, /* Timer 1 */ > - <15 IRQ_TYPE_EDGE_RISING>, /* Timer 2 */ > - <16 IRQ_TYPE_EDGE_RISING>; /* Timer 3 */ > - syscon = <&syscon>; > -}; > diff --git a/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt b/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt > new file mode 100644 > index 000000000000..b73ca6cd07f8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/faraday,fttmr010.txt > @@ -0,0 +1,33 @@ > +Faraday Technology timer > + > +This timer is a generic IP block from Faraday Technology, embedded in the > +Cortina Systems Gemini SoCs and other designs. > + > +Required properties: > + > +- compatible : Must be one of > + "faraday,fttmr010" > + "cortina,gemini-timer" > +- reg : Should contain registers location and length > +- interrupts : Should contain the three timer interrupts usually with > + flags for falling edge > + > +Optionally required properties: > + > +- clocks : a clock to provide the tick rate for "faraday,fttmr010" > +- clock-names : should be "EXTCLK" and "PCLK" for the external tick timer > + and peripheral clock respectively, for "faraday,fttmr010" > +- syscon : a phandle to the global Gemini system controller if the compatible > + type is "cortina,gemini-timer" > + > +Example: > + > +timer@43000000 { > + compatible = "faraday,fttmr010"; > + reg = <0x43000000 0x1000>; > + interrupts = <14 IRQ_TYPE_EDGE_FALLING>, /* Timer 1 */ > + <15 IRQ_TYPE_EDGE_FALLING>, /* Timer 2 */ > + <16 IRQ_TYPE_EDGE_FALLING>; /* Timer 3 */ > + clocks = <&extclk>, <&pclk>; > + clock-names = "EXTCLK", "PCLK"; > +}; > -- > 2.9.3 > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog