From: Andrew Lunn <andrew@lunn.ch>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com, kernel@pengutronix.de,
vivien.didelot@savoirfairelinux.com, davem@davemloft.net
Subject: Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support
Date: Fri, 7 Apr 2017 17:05:14 +0200 [thread overview]
Message-ID: <20170407150514.GE23415@lunn.ch> (raw)
In-Reply-To: <20170407081502.30172-5-jbe@pengutronix.de>
On Fri, Apr 07, 2017 at 10:15:02AM +0200, Juergen Borleis wrote:
> When the LAN9303 device is in MDIO manged mode, all register accesses must
> be done via MDIO.
>
> Please note: this code is *untested* yet due to the absence of such
> configured hardware. It is based on a patch of Stefan Roese from 2014.
I looked through the code and i don't see anything obviously
wrong. But so long as we get the ABI correct, we can fix everything
else later. And the ABI here is just the device tree binding. And that
is identical to the i2c binding. The properties just go in a different
place in the tree. So please do the *TODO*, you can look at other
examples, e.g. the Marvell binding documentation.
With that done, i will ACK this code.
Andrew
prev parent reply other threads:[~2017-04-07 15:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 8:14 [PATCHv2] net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver Juergen Borleis
2017-04-07 8:14 ` [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis
2017-04-07 13:06 ` Andrew Lunn
2017-04-10 7:18 ` Juergen Borleis
2017-04-10 13:15 ` Andrew Lunn
2017-04-07 8:15 ` [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis
2017-04-07 13:35 ` David Miller
2017-04-07 14:29 ` Andrew Lunn
2017-04-10 7:44 ` Juergen Borleis
2017-04-10 13:25 ` Andrew Lunn
2017-04-07 8:15 ` [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis
2017-04-07 13:40 ` Andrew Lunn
2017-04-10 7:58 ` Juergen Borleis
2017-04-07 8:15 ` [PATCH v2 4/4] net: dsa: LAN9303: add MDIO " Juergen Borleis
2017-04-07 14:19 ` Andrew Lunn
2017-04-07 14:27 ` David Miller
2017-04-07 14:54 ` Andrew Lunn
2017-04-07 15:05 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407150514.GE23415@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jbe@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).