From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934256AbdDGPGP (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Apr 2017 11:06:15 -0400
Received: from mail.kernel.org ([198.145.29.136]:47370 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933979AbdDGPGG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Apr 2017 11:06:06 -0400
Date: Fri, 7 Apr 2017 12:06:01 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/5] perf stat: Refactor the code to strip csv output
 with ltrim()
Message-ID: <20170407150601.GF2966@kernel.org>
References: <1491575061-704-1-git-send-email-treeze.taeung@gmail.com>
 <1491575061-704-3-git-send-email-treeze.taeung@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1491575061-704-3-git-send-email-treeze.taeung@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Fri, Apr 07, 2017 at 11:24:18PM +0900, Taeung Song escreveu:
> To strip csv output, use ltrim() instead of
> just while loop and isspace() at print_metric_{only}_csv().

Applied.
 
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
>  tools/perf/builtin-stat.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 2158ea1..868e086a 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -875,10 +875,7 @@ static void print_metric_csv(void *ctx,
>  		return;
>  	}
>  	snprintf(buf, sizeof(buf), fmt, val);
> -	vals = buf;
> -	while (isspace(*vals))
> -		vals++;
> -	ends = vals;
> +	ends = vals = ltrim(buf);
>  	while (isdigit(*ends) || *ends == '.')
>  		ends++;
>  	*ends = 0;
> @@ -950,10 +947,7 @@ static void print_metric_only_csv(void *ctx, const char *color __maybe_unused,
>  		return;
>  	unit = fixunit(tbuf, os->evsel, unit);
>  	snprintf(buf, sizeof buf, fmt, val);
> -	vals = buf;
> -	while (isspace(*vals))
> -		vals++;
> -	ends = vals;
> +	ends = vals = ltrim(buf);
>  	while (isdigit(*ends) || *ends == '.')
>  		ends++;
>  	*ends = 0;
> -- 
> 2.7.4