From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934444AbdDGTnM (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Apr 2017 15:43:12 -0400
Received: from mail.kernel.org ([198.145.29.136]:36710 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933568AbdDGTnI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Apr 2017 15:43:08 -0400
Date: Fri, 7 Apr 2017 15:43:04 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH 7/5 v4] tracing: Make sure rcu_irq_enter() can work for
 trace_*_rcuidle() trace events
Message-ID: <20170407154304.10a33c8c@gandalf.local.home>
In-Reply-To: <20170407154117.253c84ae@gandalf.local.home>
References: <20170407140106.051135969@goodmis.org>
        <20170407130615.2309b96d@gandalf.local.home>
        <1475342880.4473.1491585545139.JavaMail.zimbra@efficios.com>
        <20170407132613.4a9fa430@gandalf.local.home>
        <1679331943.4538.1491587357083.JavaMail.zimbra@efficios.com>
        <20170407141018.21e7d361@gandalf.local.home>
        <158560784.4550.1491589063819.JavaMail.zimbra@efficios.com>
        <20170407154117.253c84ae@gandalf.local.home>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 7 Apr 2017 15:41:17 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
 
>  #ifndef MODULE
> -#define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args)	\
> +#define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args) \
>  	static inline void trace_##name##_rcuidle(proto)		\
>  	{								\
>  		if (static_key_false(&__tracepoint_##name.key))		\
>  			__DO_TRACE(&__tracepoint_##name,		\
>  				TP_PROTO(data_proto),			\
>  				TP_ARGS(data_args),			\
> -				TP_CONDITION(cond),			\
> -				rcu_irq_enter_irqson(),			\
> -				rcu_irq_exit_irqson());			\
> +				TP_CONDITION(cond),1);			\

I'm going to update this patch to add a space before the 1.

>  	}
>  #else
>  #define __DECLARE_TRACE_RCU(name, proto, args, cond, data_proto, data_args)
> @@ -186,7 +189,7 @@ extern void syscall_unregfunc(void);
>  			__DO_TRACE(&__tracepoint_##name,		\
>  				TP_PROTO(data_proto),			\
>  				TP_ARGS(data_args),			\
> -				TP_CONDITION(cond),,);			\
> +				TP_CONDITION(cond),0);			\

And before the 0.

-- Steve

>  		if (IS_ENABLED(CONFIG_LOCKDEP) && (cond)) {		\
>  			rcu_read_lock_sched_notrace();			\
>  			rcu_dereference_sched(__tracepoint_##name.funcs);\