From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: Matthew Wilcox <mawilcox@microsoft.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] drivers: char: Replace bit operation functions with IDA allocator.
Date: Fri, 7 Apr 2017 17:45:20 +0200 [thread overview]
Message-ID: <20170407154520.GA11575@kroah.com> (raw)
In-Reply-To: <58e77955.09c3620a.bb125.3e20@mx.google.com>
On Fri, Apr 07, 2017 at 05:04:41PM +0530, Varsha Rao wrote:
> Replace bit operation functions with IDA allocator functions. As IDA
> allocation is simpler.
But why does this matter?
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> drivers/char/misc.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index c9cd1ea..5786281 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -60,7 +60,7 @@ static DEFINE_MUTEX(misc_mtx);
> * Assigned numbers, used for dynamic minors
> */
> #define DYNAMIC_MINORS 64 /* like dynamic majors */
> -static DECLARE_BITMAP(misc_minors, DYNAMIC_MINORS);
> +static DEFINE_IDA(misc_minors_ida);
>
> #ifdef CONFIG_PROC_FS
> static void *misc_seq_start(struct seq_file *seq, loff_t *pos)
> @@ -193,14 +193,18 @@ int misc_register(struct miscdevice *misc)
> mutex_lock(&misc_mtx);
>
> if (is_dynamic) {
> - int i = find_first_zero_bit(misc_minors, DYNAMIC_MINORS);
> + int i = ida_simple_get(&misc_minors_ida, 0,
> + DYNAMIC_MINORS, GFP_KERNEL);
>
> if (i >= DYNAMIC_MINORS) {
> err = -EBUSY;
> goto out;
> - }
> + } else if (i < 0) {
> + err = i;
> + goto out;
> + } else {
> misc->minor = DYNAMIC_MINORS - i - 1;
> - set_bit(i, misc_minors);
> + }
Your indentation is now incorrect :(
> } else {
> struct miscdevice *c;
>
> @@ -222,7 +226,7 @@ int misc_register(struct miscdevice *misc)
> int i = DYNAMIC_MINORS - misc->minor - 1;
>
> if (i < DYNAMIC_MINORS && i >= 0)
> - clear_bit(i, misc_minors);
> + ida_simple_remove(&misc_minors_ida, i);
> misc->minor = MISC_DYNAMIC_MINOR;
> }
> err = PTR_ERR(misc->this_device);
> @@ -258,7 +262,7 @@ void misc_deregister(struct miscdevice *misc)
> list_del(&misc->list);
> device_destroy(misc_class, MKDEV(MISC_MAJOR, misc->minor));
> if (i < DYNAMIC_MINORS && i >= 0)
> - clear_bit(i, misc_minors);
> + ida_simple_remove(&misc_minors_ida, i);
As much as I like the ida interface, I don't see why it is required to
use it here, you have not provided any justification for this patch at
all :(
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-07 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1491563538.git.rvarsha016@gmail.com>
2017-04-07 11:28 ` [PATCH 1/5] drivers: char: Replace "foo * bar" with "foo *bar" Varsha Rao
2017-04-07 11:31 ` [PATCH 2/5] drivers: char: Add space after ',' Varsha Rao
2017-04-07 11:32 ` [PATCH 3/5] drivers: char: Add blank line after declaration Varsha Rao
2017-04-07 11:34 ` [PATCH 4/5] drivers: char: Replace printk with pr_err Varsha Rao
2017-04-07 15:46 ` Greg Kroah-Hartman
2017-04-07 11:34 ` [PATCH 5/5] drivers: char: Replace bit operation functions with IDA allocator Varsha Rao
2017-04-07 15:45 ` Greg Kroah-Hartman [this message]
[not found] ` <CAAFX7JSPg1s8qT5Qr=Z+QnuUYpjvyFr7T_Qf_3D08ecT3P65SQ@mail.gmail.com>
[not found] ` <CAAFX7JSQ349OQ1kAXqGX7ozRTWdqqDm6tC1FW1MbyvjR6h32Bw@mail.gmail.com>
2017-04-09 5:20 ` Varsha Rao
[not found] <cover.1491235332.git.rvarsha016@gmail.com>
2017-04-03 16:11 ` Varsha Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407154520.GA11575@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).