From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934259AbdDGQjm (ORCPT ); Fri, 7 Apr 2017 12:39:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:33482 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755546AbdDGQjf (ORCPT ); Fri, 7 Apr 2017 12:39:35 -0400 Date: Fri, 7 Apr 2017 18:39:32 +0200 From: Michal Hocko To: Hugh Dickins Cc: Andrew Morton , Mel Gorman , Tejun Heo , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: Is it safe for kthreadd to drain_all_pages? Message-ID: <20170407163932.GJ16413@dhcp22.suse.cz> References: <20170406130614.a6ygueggpwseqysd@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 07-04-17 09:25:33, Hugh Dickins wrote: [...] > 24 hours so far, and with a clean /var/log/messages. Not conclusive > yet, and of course I'll leave it running another couple of days, but > I'm increasingly sure that it works as you intended: I agree that > > mm-move-pcp-and-lru-pcp-drainging-into-single-wq.patch > mm-move-pcp-and-lru-pcp-drainging-into-single-wq-fix.patch > > should go to Linus as soon as convenient. Though I think the commit > message needs something a bit stronger than "Quite annoying though". > Maybe add a line: > > Fixes serious hang under load, observed repeatedly on 4.11-rc. Yeah, it is much less theoretical now. I will rephrase and ask Andrew to update the chagelog and send it to Linus once I've got your final go. Thanks! -- Michal Hocko SUSE Labs