From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934697AbdDGSC4 (ORCPT ); Fri, 7 Apr 2017 14:02:56 -0400 Received: from 82-70-136-246.dsl.in-addr.zen.co.uk ([82.70.136.246]:53574 "EHLO devhw0" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752130AbdDGSCr (ORCPT ); Fri, 7 Apr 2017 14:02:47 -0400 X-Greylist: delayed 2052 seconds by postgrey-1.27 at vger.kernel.org; Fri, 07 Apr 2017 14:02:46 EDT From: Ben Dooks To: linux-kernel@lists.codethink.co.uk, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ben Dooks Subject: [PATCH 1/1] memory: tegra: fix fdc test bug Date: Fri, 7 Apr 2017 18:28:20 +0100 Message-Id: <20170407172820.21292-1-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The fdc variable is a bool, taking the address of this will generally produce true, thus skewing any users of the tegra_mc_set_latency_allowance code. Note, this does not seem to be producing a compiler warning. This was only spotted as it meant a caller was seeing 3 times higher than expected register results. Signed-off-by: Ben Dooks --- drivers/memory/tegra/mc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c index fb44d1741862..e20470736319 100644 --- a/drivers/memory/tegra/mc.c +++ b/drivers/memory/tegra/mc.c @@ -121,7 +121,7 @@ int tegra_mc_set_latency_allowance(int client_id, unsigned int bandwidth) WARN_ON(client->id != client_id); - if (&client->fdc) + if (client->fdc) atom_bytes = plat_mc->soc->atom_size_fdc; else atom_bytes = plat_mc->soc->atom_size; -- 2.11.0