From: Thierry Reding <thierry.reding@gmail.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk, swarren@wwwdotorg.org,
gnurou@gmail.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] memory: tegra: fix fdc test bug
Date: Fri, 7 Apr 2017 19:43:01 +0200 [thread overview]
Message-ID: <20170407174301.GA4386@ulmo.ba.sec> (raw)
In-Reply-To: <20170407172820.21292-1-ben.dooks@codethink.co.uk>
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
On Fri, Apr 07, 2017 at 06:28:20PM +0100, Ben Dooks wrote:
> The fdc variable is a bool, taking the address of this will generally
> produce true, thus skewing any users of the tegra_mc_set_latency_allowance
> code.
>
> Note, this does not seem to be producing a compiler warning. This was only
> spotted as it meant a caller was seeing 3 times higher than expected
> register results.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> drivers/memory/tegra/mc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What tree is this based on? I don't see this code anywhere in mainline.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-07 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 17:28 [PATCH 1/1] memory: tegra: fix fdc test bug Ben Dooks
2017-04-07 17:43 ` Thierry Reding [this message]
2017-04-07 21:54 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407174301.GA4386@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=gnurou@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).