linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Jonathan Woithe <jwoithe@just42.net>
Cc: Micha?? K??pie?? <kernel@kempniu.pl>,
	Andy Shevchenko <andy@infradead.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup
Date: Fri, 7 Apr 2017 10:57:36 -0700	[thread overview]
Message-ID: <20170407175736.GB2229@fury> (raw)
In-Reply-To: <20170407121135.GD15240@marvin.atrad.com.au>

On Fri, Apr 07, 2017 at 09:41:35PM +0930, Jonathan Woithe wrote:
> On Wed, Apr 05, 2017 at 08:07:54PM -0700, Darren Hart wrote:
> > On Thu, Apr 06, 2017 at 10:15:14AM +0930, Jonathan Woithe wrote:
> > > On Wed, Apr 05, 2017 at 09:55:34PM +0200, Micha?? K??pie?? wrote:
> > > > > On Wed, Apr 05, 2017 at 08:48:59AM +0200, Micha?? K??pie?? wrote:
> > > > > > This series introduces further changes to the way LCD backlight is
> > > > > > handled by fujitsu-laptop.  These changes include fixing a bug in code
> > > > > > responsible for generating brightness-related input events, cleaning up
> > > > > > handling of module parameters, reducing code duplication, removing
> > > > > > superfluous debug messages and other fixes.
> > > > > > 
> > > > > > This series was tested on a Lifebook S7020 and a Lifebook E744.
> > > > > > 
> > > > > > This series is based on the testing branch as it requires earlier patch
> > > > > > series I submitted in order to apply cleanly.
> > > > > > 
> > > > > > Changes from v1:
> > > > > > 
> > > > > >   - Update debug message logged by set_lcd_level() to reflect code flow
> > > > > >     changes introduced by patch 04/11.
> > > > > 
> > > > > Queued to testing, thanks! 
> > > > 
> > > > Jonathan, I would still love to hear your opinion on this series.  Take
> > > > your time, though, I do not see any reason to rush things.  I will only
> > > > send the next series once you ack this one.
> > > 
> > > Sure, no problem.  As mentioned earlier, this week has been busy.  I am
> > > hoping I might find the time to complete my review this evening.  If not, it
> > > will be some time over the weekend.
> > 
> > Eeek, I jumped the gun on that. I've moved this from testing to fujitsu, and
> > it'll wait there until Jonathan gets a chance to review. Apologies Jonathan.
> 
> That's fine, these things happen.
> 
> I've completed a review of this series.  It represents another worthwhile
> evolutionary clean up of the fujitsu-laptop driver, this time concentrating
> on the backlight functions.  Importantly, it makes adjustments for changes
> in related kernel infrastructure as it has evolved over the last few
> years (the handling of module parameters, method return values and so on).
> 
> I am happy for this series to be merged.  Thanks Michael for your continued
> clean up efforts.
> 
> Reviewed-by: Jonathan Woithe <jwoithe@just42.net>

Queued to testing, thanks!

-- 
Darren Hart
VMware Open Source Technology Center

      reply	other threads:[~2017-04-07 17:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05  6:48 [PATCH v2 00/11] fujitsu-laptop: backlight cleanup Michał Kępień
2017-04-05  6:49 ` [PATCH v2 01/11] platform/x86: fujitsu-laptop: only handle backlight when appropriate Michał Kępień
2017-04-05  6:49 ` [PATCH v2 02/11] platform/x86: fujitsu-laptop: switch to a managed backlight device Michał Kępień
2017-04-05  6:49 ` [PATCH v2 03/11] platform/x86: fujitsu-laptop: merge set_lcd_level_alt() into set_lcd_level() Michał Kępień
2017-04-07 11:53   ` Jonathan Woithe
2017-04-07 12:03     ` Jonathan Woithe
2017-04-05  6:49 ` [PATCH v2 04/11] platform/x86: fujitsu-laptop: simplify set_lcd_level() Michał Kępień
2017-04-05  6:49 ` [PATCH v2 05/11] platform/x86: fujitsu-laptop: sync brightness in set_lcd_level() Michał Kępień
2017-04-05  6:49 ` [PATCH v2 06/11] platform/x86: fujitsu-laptop: clean up use_alt_lcd_levels handling Michał Kępień
2017-04-05  6:49 ` [PATCH v2 07/11] platform/x86: fujitsu-laptop: make disable_brightness_adjust a boolean Michał Kępień
2017-04-05  6:49 ` [PATCH v2 08/11] platform/x86: fujitsu-laptop: ignore errors when setting backlight power Michał Kępień
2017-04-05  6:49 ` [PATCH v2 09/11] platform/x86: fujitsu-laptop: do not log set_lcd_level() failures in bl_update_status() Michał Kępień
2017-04-05  6:49 ` [PATCH v2 10/11] platform/x86: fujitsu-laptop: account for backlight power when determining brightness Michał Kępień
2017-04-05  6:49 ` [PATCH v2 11/11] platform/x86: fujitsu-laptop: remove redundant fields from struct fujitsu_bl Michał Kępień
2017-04-05 15:36 ` [PATCH v2 00/11] fujitsu-laptop: backlight cleanup Darren Hart
2017-04-05 19:55   ` Michał Kępień
2017-04-06  0:45     ` Jonathan Woithe
2017-04-06  3:07       ` Darren Hart
2017-04-07 12:11         ` Jonathan Woithe
2017-04-07 17:57           ` Darren Hart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407175736.GB2229@fury \
    --to=dvhart@infradead.org \
    --cc=andy@infradead.org \
    --cc=jwoithe@just42.net \
    --cc=kernel@kempniu.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).