From: David Miller <davem@davemloft.net>
To: ksiva@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, tlfalcon@linux.vnet.ibm.com,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
brking@linux.vnet.ibm.com, seroyer@linux.vnet.ibm.com
Subject: Re: [PATCH] ibmveth: Support to enable LSO/CSO for Trunk VEA.
Date: Sat, 08 Apr 2017 11:45:15 -0700 (PDT) [thread overview]
Message-ID: <20170408.114515.1339820744697810446.davem@davemloft.net> (raw)
In-Reply-To: <1491559079-10855-1-git-send-email-ksiva@linux.vnet.ibm.com>
From: Sivakumar Krishnasamy <ksiva@linux.vnet.ibm.com>
Date: Fri, 7 Apr 2017 05:57:59 -0400
> Enable largesend and checksum offload for ibmveth configured in trunk mode.
> Added support to SKB frag_list in TX path by skb_linearize'ing such SKBs.
>
> Signed-off-by: Sivakumar Krishnasamy <ksiva@linux.vnet.ibm.com>
Why is linearization necessary?
It would seem that the gains you get from GRO are nullified by
linearizing the SKB and thus copying all the data around and
allocating buffers.
Finally, all of that new checksumming stuff looks extremely
suspicious. You have to explain why that is happening and why it
isn't because this driver is doing something incorrectly.
Thanks.
next prev parent reply other threads:[~2017-04-08 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 9:57 [PATCH] ibmveth: Support to enable LSO/CSO for Trunk VEA Sivakumar Krishnasamy
2017-04-08 18:45 ` David Miller [this message]
2017-04-11 4:23 ` Sivakumar Krishnasamy
2017-05-19 9:30 ` [PATCH net-next v2] " Sivakumar Krishnasamy
2017-05-21 17:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170408.114515.1339820744697810446.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=brking@linux.vnet.ibm.com \
--cc=ksiva@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=seroyer@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).