From: "Denis 'GNUtoo' Carikli" <GNUtoo@no-log.org> To: Paul Menzel <firstname.lastname@example.org> Cc: Jason Gunthorpe <email@example.com>, "Maciej S. Szmigiero" <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot Date: Sat, 8 Apr 2017 12:40:25 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20170406165557.GD7657@obsidianresearch.com> [-- Attachment #1: Type: text/plain, Size: 1510 bytes --] Hi Paul, On Thu, 6 Apr 2017 10:55:57 -0600 Jason Gunthorpe <firstname.lastname@example.org> wrote: > We added direct ACPI binding to the driver in addition to PNP, so if > you have an ACPI table it goes down that path and does some additional > validation of what is in the TPM. The BIOS must provide a > acpi_dev_resource_memory and a ACPI_SIG_TPM2 for the ACPI entry at a > minimum. I am working on it. This commit has not been merged and is a work in progress. It is however available in coreboot's gerrit. So far with it and a recent kernel and the patch mentioned above: - The linux driver finds the TPM automatically and doesn't require force=1 - The driver however still require itpm=1 to fully work: without it the tpm is found, but I wasn't able to read the PCRs. Since I use a rolling release distribution, the kenrel version I use tend to change quite fast, I can re-test if needed. I need to improve the following in my patch: - The IDs readings obviously need to be fixed. - I want to make it work without itpm=1 if possible. I'll test with INTC0102 as it is in the driver in the is_itpm function, and it was also suggested to me by someone on IRC. I also still need to investigate more why the itpm workaround is needed. Does the TPM shipped in such laptops respect the specifications? Is the wiring bad? References: ----------- https://review.coreboot.org/cgit/coreboot.git/commit/?id=060cf4e0f50f765f85e3ecedd836eed85d1571fe Denis. [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-08 11:26 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-05 11:03 Maciej S. Szmigiero 2017-04-05 13:36 ` Jarkko Sakkinen 2017-04-06 6:18 ` Paul Menzel 2017-04-06 11:52 ` Maciej S. Szmigiero 2017-04-06 16:55 ` Jason Gunthorpe 2017-04-06 18:26 ` Paul Menzel 2017-04-06 19:10 ` Jason Gunthorpe 2017-04-07 20:13 ` Jarkko Sakkinen 2017-04-07 20:58 ` Paul Menzel 2017-04-09 17:34 ` [Regression Linux 4.11] TPM module not loaded anymore (was: Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot) Paul Menzel 2017-04-11 22:57 ` Jarkko Sakkinen 2017-04-12 15:46 ` Moore, Robert 2017-04-12 15:52 ` Moore, Robert 2017-04-12 15:54 ` Moore, Robert 2017-04-12 21:26 ` [Regression Linux 4.11] TPM module not loaded anymore Paul Menzel 2017-04-12 21:49 ` Moore, Robert 2017-04-13 7:19 ` Paul Menzel 2017-04-06 18:58 ` [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot Jarkko Sakkinen 2017-04-08 10:40 ` Denis 'GNUtoo' Carikli [this message] 2017-04-08 20:25 ` Jason Gunthorpe -- strict thread matches above, loose matches on Subject: below -- 2017-04-04 16:29 Paul Menzel 2017-04-04 17:15 ` [tpmdd-devel] " Jason Gunthorpe 2017-04-04 17:44 ` Paul Menzel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).