From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799AbdDHPY1 (ORCPT ); Sat, 8 Apr 2017 11:24:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43392 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752648AbdDHPYL (ORCPT ); Sat, 8 Apr 2017 11:24:11 -0400 Date: Sat, 8 Apr 2017 17:23:59 +0200 From: Greg KH To: David Howells Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, gnomes@lxorguk.ukuu.org.uk, speakup@linux-speakup.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 29/38] Annotate hardware config module parameters in drivers/staging/speakup/ Message-ID: <20170408152359.GE7879@kroah.com> References: <149141141298.29162.5612793122429261720.stgit@warthog.procyon.org.uk> <149141167058.29162.7142804081158375419.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149141167058.29162.7142804081158375419.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 05, 2017 at 06:01:10PM +0100, David Howells wrote: > When the kernel is running in secure boot mode, we lock down the kernel to > prevent userspace from modifying the running kernel image. Whilst this > includes prohibiting access to things like /dev/mem, it must also prevent > access by means of configuring driver modules in such a way as to cause a > device to access or modify the kernel image. > > To this end, annotate module_param* statements that refer to hardware > configuration and indicate for future reference what type of parameter they > specify. The parameter parser in the core sees this information and can > skip such parameters with an error message if the kernel is locked down. > The module initialisation then runs as normal, but just sees whatever the > default values for those parameters is. > > Note that we do still need to do the module initialisation because some > drivers have viable defaults set in case parameters aren't specified and > some drivers support automatic configuration (e.g. PNP or PCI) in addition > to manually coded parameters. > > This patch annotates drivers in drivers/staging/speakup/. > > Suggested-by: Alan Cox > Signed-off-by: David Howells > cc: Greg Kroah-Hartman > cc: speakup@linux-speakup.org > cc: devel@driverdev.osuosl.org Acked-by: Greg Kroah-Hartman