From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752491AbdDHQLz (ORCPT <rfc822;w@1wt.eu>);
        Sat, 8 Apr 2017 12:11:55 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:45008 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751542AbdDHQLs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 8 Apr 2017 12:11:48 -0400
Date: Sat, 8 Apr 2017 18:11:36 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] char: misc: minor code cleanup
Message-ID: <20170408161136.GA19880@kroah.com>
References: <1488234485-26111-1-git-send-email-martin@kaiser.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1488234485-26111-1-git-send-email-martin@kaiser.cx>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 27, 2017 at 11:27:58PM +0100, Martin Kaiser wrote:
> Fix a couple of minor issues found by checkpatch.pl:
> 
> Add/remove spaces where required.
> Move EXPORT_SYMBOL() to the end of the function it refers to.
> Set the access mode for the proc entry explicity.
> Use pr_warn() instead of printk() without loglevel.

Always break up patches to only do 1 thing per patch.

thanks,

greg k-h