From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753892AbdDJPGX (ORCPT ); Mon, 10 Apr 2017 11:06:23 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:37282 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdDJPFS (ORCPT ); Mon, 10 Apr 2017 11:05:18 -0400 Date: Mon, 10 Apr 2017 16:05:03 +0100 From: Russell King - ARM Linux To: Juri Lelli Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, morten.rasmussen@arm.com, dietmar.eggemann@arm.com, broonie@kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code Message-ID: <20170410150503.GS17774@n2100.armlinux.org.uk> References: <20170327131825.32134-1-juri.lelli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327131825.32134-1-juri.lelli@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 27, 2017 at 02:18:16PM +0100, Juri Lelli wrote: > arm and arm64 topology.c share a lot of code related to parsing of capacity > information. This is v3 of a solution [1] (based on Will's, Catalin's and > Mark's off-line suggestions) to move such common code in a single place: > drivers/base/arch_topology.c (by creating such file and conditionally compiling > it for arm and arm64 only). I think overall this is okay, with the exception of one patch which seems to be wrongly worded. Once that's resolved, then: Acked-by: Russell King for the series. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.