From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
<kernel-team@lge.com>
Subject: Re: [PATCH 0/5] zram clean up
Date: Tue, 11 Apr 2017 14:38:30 +0900 [thread overview]
Message-ID: <20170411053830.GA20340@bbox> (raw)
In-Reply-To: <1491196653-7388-1-git-send-email-minchan@kernel.org>
Hi Andrew,
Could you drop this patchset?
I will send updated version based on Sergey with some bug fixes.
zram-handle-multiple-pages-attached-bios-bvec.patch
zram-partial-io-refactoring.patch
zram-use-zram_slot_lock-instead-of-raw-bit_spin_lock-op.patch
zram-remove-zram_meta-structure.patch
zram-introduce-zram-data-accessor.patch
Thanks!
On Mon, Apr 03, 2017 at 02:17:28PM +0900, Minchan Kim wrote:
> This patchset aims zram clean-up.
>
> [1] clean up multiple pages's bvec handling.
> [2] clean up partial IO handling
> [3-5] clean up zram via using accessor and removing pointless structure.
>
> With [2-5] applied, we can get a few hundred bytes as well as huge
> readibility enhance.
>
> This patchset is based on v4.11-rc4-mmotm-2017-03-30-16-31 and
> *drop* zram-factor-out-partial-io-routine.patch.
>
> x86: 708 byte save
>
> add/remove: 1/1 grow/shrink: 0/11 up/down: 478/-1186 (-708)
> function old new delta
> zram_special_page_read - 478 +478
> zram_reset_device 317 314 -3
> mem_used_max_store 131 128 -3
> compact_store 96 93 -3
> mm_stat_show 203 197 -6
> zram_add 719 712 -7
> zram_slot_free_notify 229 214 -15
> zram_make_request 819 803 -16
> zram_meta_free 128 111 -17
> zram_free_page 180 151 -29
> disksize_store 432 361 -71
> zram_decompress_page.isra 504 - -504
> zram_bvec_rw 2592 2080 -512
> Total: Before=25350773, After=25350065, chg -0.00%
>
> ppc64: 231 byte save
>
> add/remove: 2/0 grow/shrink: 1/9 up/down: 681/-912 (-231)
> function old new delta
> zram_special_page_read - 480 +480
> zram_slot_lock - 200 +200
> vermagic 39 40 +1
> mm_stat_show 256 248 -8
> zram_meta_free 200 184 -16
> zram_add 944 912 -32
> zram_free_page 348 308 -40
> disksize_store 572 492 -80
> zram_decompress_page 664 564 -100
> zram_slot_free_notify 292 160 -132
> zram_make_request 1132 1000 -132
> zram_bvec_rw 2768 2396 -372
> Total: Before=17565825, After=17565594, chg -0.00%
>
> Minchan Kim (5):
> [1] zram: handle multiple pages attached bio's bvec
> [2] zram: partial IO refactoring
> [3] zram: use zram_slot_lock instead of raw bit_spin_lock op
> [4] zram: remove zram_meta structure
> [5] zram: introduce zram data accessor
>
> drivers/block/zram/zram_drv.c | 532 +++++++++++++++++++++---------------------
> drivers/block/zram/zram_drv.h | 6 +-
> 2 files changed, 270 insertions(+), 268 deletions(-)
>
> --
> 2.7.4
>
prev parent reply other threads:[~2017-04-11 5:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 5:17 [PATCH 0/5] zram clean up Minchan Kim
2017-04-03 5:17 ` [PATCH 1/5] zram: handle multiple pages attached bio's bvec Minchan Kim
2017-04-03 22:45 ` Andrew Morton
2017-04-03 23:13 ` Minchan Kim
2017-04-04 4:55 ` Sergey Senozhatsky
2017-04-03 5:17 ` [PATCH 2/5] zram: partial IO refactoring Minchan Kim
2017-04-03 5:52 ` Mika Penttilä
2017-04-03 6:12 ` Minchan Kim
2017-04-03 6:57 ` Mika Penttilä
2017-04-04 2:17 ` Sergey Senozhatsky
2017-04-04 4:50 ` Minchan Kim
2017-04-03 5:17 ` [PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op Minchan Kim
2017-04-03 6:08 ` Sergey Senozhatsky
2017-04-03 6:34 ` Minchan Kim
2017-04-03 8:06 ` Sergey Senozhatsky
2017-04-04 2:18 ` Sergey Senozhatsky
2017-04-04 4:50 ` Minchan Kim
2017-04-03 5:17 ` [PATCH 4/5] zram: remove zram_meta structure Minchan Kim
2017-04-04 2:31 ` Sergey Senozhatsky
2017-04-04 4:52 ` Minchan Kim
2017-04-04 5:40 ` Minchan Kim
2017-04-04 5:54 ` Sergey Senozhatsky
2017-04-03 5:17 ` [PATCH 5/5] zram: introduce zram data accessor Minchan Kim
2017-04-04 4:40 ` Sergey Senozhatsky
2017-04-11 5:38 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411053830.GA20340@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).