archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <>
Cc: Alexey Kardashevskiy <>,
	Balbir Singh <>,
	Michael Ellerman <>,
	"Aneesh Kumar K . V" <>,
	Greg Kurz <>, Paul Mackerras <>,,,,
Subject: [PATCH kernel v2] powerpc/iommu: Do not call PageTransHuge() on tail pages
Date: Tue, 11 Apr 2017 17:54:57 +1000	[thread overview]
Message-ID: <> (raw)

The CMA pages migration code does not support compound pages at
the moment so it performs few tests before proceeding to actual page

One of the tests - PageTransHuge() - has VM_BUG_ON_PAGE(PageTail()) as
it is designed to be called on head pages only. Since we also test for
PageCompound(), and it contains PageTail() and PageHead(), we can
simplify the check by leaving just PageCompound() and therefore avoid
possible VM_BUG_ON_PAGE.

Fixes: 2e5bbb5461f1 ("KVM: PPC: Book3S HV: Migrate pinned pages out of CMA")
Cc: # v4.9+
Signed-off-by: Alexey Kardashevskiy <>
Acked-by: Balbir Singh <>

* instead of moving PageCompound() to the beginning, this just drops
PageHuge() and PageTransHuge()

 arch/powerpc/mm/mmu_context_iommu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/mm/mmu_context_iommu.c b/arch/powerpc/mm/mmu_context_iommu.c
index 497130c5c742..96f835cbf212 100644
--- a/arch/powerpc/mm/mmu_context_iommu.c
+++ b/arch/powerpc/mm/mmu_context_iommu.c
@@ -81,7 +81,7 @@ struct page *new_iommu_non_cma_page(struct page *page, unsigned long private,
 	gfp_t gfp_mask = GFP_USER;
 	struct page *new_page;
-	if (PageHuge(page) || PageTransHuge(page) || PageCompound(page))
+	if (PageCompound(page))
 		return NULL;
 	if (PageHighMem(page))
@@ -100,7 +100,7 @@ static int mm_iommu_move_page_from_cma(struct page *page)
 	/* Ignore huge pages for now */
-	if (PageHuge(page) || PageTransHuge(page) || PageCompound(page))
+	if (PageCompound(page))
 		return -EBUSY;

             reply	other threads:[~2017-04-11  8:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11  7:54 Alexey Kardashevskiy [this message]
2017-04-11  8:20 ` Balbir Singh
2017-04-19 22:04 ` [kernel,v2] " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH kernel v2] powerpc/iommu: Do not call PageTransHuge() on tail pages' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).