From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752246AbdDLG0s (ORCPT ); Wed, 12 Apr 2017 02:26:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60098 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbdDLG0o (ORCPT ); Wed, 12 Apr 2017 02:26:44 -0400 Date: Wed, 12 Apr 2017 08:26:34 +0200 From: Greg Kroah-Hartman To: Guenter Roeck Cc: Tony Lindgren , linux-kernel@vger.kernel.org, Linus Torvalds , akpm@linux-foundation.org, shuahkh@osg.samsung.com, patches@kernelci.org, ben.hutchings@codethink.co.uk, stable@vger.kernel.org, Sean Young Subject: Re: [PATCH 4.9 000/152] 4.9.22-stable review Message-ID: <20170412062634.GA1121@kroah.com> References: <20170410164159.934755016@linuxfoundation.org> <38bcb13d-1a22-3f52-21a6-c91f83631a72@roeck-us.net> <20170411044236.GB31847@kroah.com> <20170411151659.GH5339@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 11, 2017 at 06:40:30PM -0700, Guenter Roeck wrote: > On 04/11/2017 08:17 AM, Tony Lindgren wrote: > > * Greg Kroah-Hartman [170410 21:45]: > > > On Mon, Apr 10, 2017 at 08:07:17PM -0700, Guenter Roeck wrote: > > > > The arm builds fail as follows. > > > > > > > > Building arm:overo:omap2plus_defconfig:omap3-overo-tobi ... failed > > > > ------------ > > > > Error log: > > > > In file included from arch/arm/mach-omap2/pdata-quirks.c:15:0: > > > > arch/arm/mach-omap2/pdata-quirks.c:537:49: error: 'rx51_ir_data' undeclared here (not in a function) > > > > OF_DEV_AUXDATA("nokia,n900-ir", 0, "n900-ir", &rx51_ir_data), > > > > ^ > > > > ./include/linux/of_platform.h:52:21: note: in definition of macro 'OF_DEV_AUXDATA' > > > > .platform_data = _pdata } > > > > ^ > > > > make[1]: *** [arch/arm/mach-omap2/pdata-quirks.o] Error 1 > > > > > > > > I am a bit lost here. Reverting > > > > > > > > f2ea7a5c3730 rx51: broken build > > > > > > > > fixes the problem, but is supposed to accomplish the opposite. You'll need to drop > > > > that patch, or maybe even better drop > > > > Just trying to understand what's going on.. OK so dropping the patch > > above makes sense. It seems there's some other dependency not mentioned > > there. > > > > > > 375a81645446 ARM: OMAP2+: Fix init for multiple quirks for the same SoC > > > > > > > > as well and let the authors [copied] sort this out. > > > > Guenter, what's your reasoning to also drop this one? I don't quite see > > the connection between these two patches? > > > > Somehow I thought they are related, but right now I have no idea why I thought that. > Maybe I didn't have enough coffee :-(. I'm frustrated enough at this mess that it's not a big deal to drop them, if Sasha feels they are really needed, we can re-add them later :) thanks, greg k-h