From: Lee Jones <lee.jones@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: sboyd@codeaurora.org, mturquette@baylibre.com,
xuwei5@hisilicon.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH V2] clk: hi6220: Add the hi655x's pmic clock
Date: Wed, 12 Apr 2017 09:00:38 +0100 [thread overview]
Message-ID: <20170412080038.kk4vrjhvr3eao26q@dell> (raw)
In-Reply-To: <20170411211936.GT2078@mai>
On Tue, 11 Apr 2017, Daniel Lezcano wrote:
> On Tue, Apr 11, 2017 at 03:06:13PM +0100, Lee Jones wrote:
> > On Sat, 08 Apr 2017, Daniel Lezcano wrote:
> >
> > > The hi655x multi function device is a PMIC providing regulators.
> > >
> > > The PMIC also provides a clock for the WiFi and the Bluetooth, let's implement
> > > this clock in order to add it in the hi655x MFD and allow proper wireless
> > > initialization.
> > >
> > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > > ---
> > >
> > > Changelog:
> > >
> > > V2:
> > > - Added COMPILE_TEST option, compiled on x86
> > > - Removed useless parenthesis
> > > - Used of_clk_hw_simple_get() instead of deref dance
> > > - Do bailout if the clock-names is not specified
> > > - Rollback on error
> > > - Folded mfd line change and binding
> >
> > Why did you do that?
>
> I thought as the V1 had comments you would have waited for the V2 and as it was
> trivial enough, it could be folded and picked up via the clk tree via with your
> acked-by.
It's *always* a good idea to keep patches subsystem orthogonal if
at all possible.
> I realize it was not a good idea.
>
> Do you want to drop it from your tree or shall I resubmit a V3 without the mfd
> change?
The latter please.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-04-12 8:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 20:30 Daniel Lezcano
2017-04-11 14:06 ` Lee Jones
2017-04-11 21:19 ` Daniel Lezcano
2017-04-12 8:00 ` Lee Jones [this message]
2017-04-12 12:10 ` Daniel Lezcano
2017-04-12 13:34 ` Lee Jones
2017-04-12 15:02 ` Stephen Boyd
2017-04-16 20:57 ` Daniel Lezcano
2017-04-19 16:00 ` Stephen Boyd
2017-04-19 19:47 ` Daniel Lezcano
2017-04-22 2:14 ` Stephen Boyd
2017-04-24 9:31 ` Lee Jones
2017-04-24 9:43 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412080038.kk4vrjhvr3eao26q@dell \
--to=lee.jones@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=xuwei5@hisilicon.com \
--subject='Re: [PATCH V2] clk: hi6220: Add the hi655x'\''s pmic clock' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).