From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494AbdDLJVR (ORCPT ); Wed, 12 Apr 2017 05:21:17 -0400 Received: from mail.skyhub.de ([5.9.137.197]:38386 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbdDLJVP (ORCPT ); Wed, 12 Apr 2017 05:21:15 -0400 Date: Wed, 12 Apr 2017 11:21:01 +0200 From: Borislav Petkov To: Christoph Hellwig Cc: Sergey Temerkhanov , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: please use pci_alloc_irq_vectors in thunderx_edac. Message-ID: <20170412092101.cg63lwzwl44arukk@pd.tnic> References: <20170412060559.GA20471@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170412060559.GA20471@lst.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 08:06:00AM +0200, Christoph Hellwig wrote: > Hi Sergey, > > you're new thunderx_edac driver uses pci_enable_msix_exact for no > good reason. Can you please switch it to use pci_alloc_irq_vectors > before it gets merged to mainline? Do we need to mark pci_enable_msix_exact() deprecated or so, or maybe a checkpatch rule? It says so in some text file in Documentation: 4.3 Legacy APIs The following old APIs to enable and disable MSI or MSI-X interrupts should not be used in new code: pci_enable_msi() /* deprecated */ pci_disable_msi() /* deprecated */ pci_enable_msix_range() /* deprecated */ pci_enable_msix_exact() /* deprecated */ pci_disable_msix() /* deprecated */ but maybe we should enforce it? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.