From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753989AbdDLMjX (ORCPT ); Wed, 12 Apr 2017 08:39:23 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:55996 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753723AbdDLMjU (ORCPT ); Wed, 12 Apr 2017 08:39:20 -0400 Date: Wed, 12 Apr 2017 14:39:08 +0200 From: Maxime Ripard To: Corentin Labbe Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, linux-sunxi@googlegroups.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 08/18] arm: sun8i: orangepi-pc: Enable dwmac-sun8i Message-ID: <20170412123908.vho6eodh4p3t7fry@lukather> References: <20170412111400.2296-1-clabbe.montjoie@gmail.com> <20170412111400.2296-9-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d4sutcdjykfj5rbu" Content-Disposition: inline In-Reply-To: <20170412111400.2296-9-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --d4sutcdjykfj5rbu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Corentin, On Wed, Apr 12, 2017 at 01:13:50PM +0200, Corentin Labbe wrote: > The dwmac-sun8i hardware is present on the Orange PI PC. > It uses the internal PHY. >=20 > This patch create the needed emac node. >=20 > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/d= ts/sun8i-h3-orangepi-pc.dts > index f148111..746c25a 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts > @@ -53,6 +53,7 @@ > =20 > aliases { > serial0 =3D &uart0; > + ethernet0 =3D &emac; Sorry for not spotting this earlier... This should be ordered by alphabetical order,=20 > }; > =20 > chosen { > @@ -184,3 +185,10 @@ > /* USB VBUS is always on */ > status =3D "okay"; > }; > + > +&emac { > + phy-handle =3D <&int_mii_phy>; > + phy-mode =3D "mii"; > + allwinner,leds-active-low; > + status =3D "okay"; > +}; And the node here as well. Almost all your other DT patches also have this issue, please fix it in all of them. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --d4sutcdjykfj5rbu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJY7h/oAAoJEBx+YmzsjxAgI6wP/2T6s0Hxprk0J8RLAN2dI5T5 kTgM7IpAiaK2CcuoQl0iFo1iug1iWKjQgFIU+ma4ZM+tKN+LinosdnBn9HpFEO/n EOnljNsai9Puhbc/H89eaiN+d4BFouokmmW/Sip4bQ4zd/tI1y1DbZA7m/0zx5Lx 5ernSwTYq4VmjmeZSeBAENhtBLdLJAl1k/ufNZEKq0L8jsD90T20EpKovK+YopOm zuDqz6w0H16xr8A0FDcfUnkrD9BCrGq776UOu0hxtWVOrXJNytXXUL3QFqUKurq4 ODAtkskGO2zU8HsTMALKdFddLyEsiPtEVwFwf6FY4Dkvc4WqK9Jg0c1CHBMZ/zWo G6y41cx0oywjVQkPsvAKwpLaiGhZBJlXTnymcPkuIFdjOA9ZUifw3g3UdakMSGJE ECVzgS0+/fRngbYraVODlJk9K653BbL1723BQqili/BGS1mUrW6ssX8RBOA4HopI SjkwpiwB+csdGgnZKmCmpwgQDMvs0MTK0mSAyT4SyoMt2XOE7wevdsIzoEY2DfMC OkaE/CFCcHioJtie4JAiNHb8LIU3/TRMiQO6uizLmI9HS4WQcZ2sqD/EnsK7D6fX O6ajFJoV3WzINOzOg5IP/v+vaxfdm+RQ+cFoWcEXyyQIVz5waPCqPXBW1GbfXTiZ a0BSEq8pPyKh3iflnwO7 =VycO -----END PGP SIGNATURE----- --d4sutcdjykfj5rbu--