From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
Gustavo Padovan <gustavo.padovan@collabora.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/vc4: Add support for dma-buf fencing.
Date: Wed, 12 Apr 2017 14:49:04 +0200 [thread overview]
Message-ID: <20170412124904.4f7bot45rcesqnrz@phenom.ffwll.local> (raw)
In-Reply-To: <87mvbmx2k8.fsf@eliezer.anholt.net>
On Tue, Apr 11, 2017 at 10:43:35AM -0700, Eric Anholt wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > On Mon, Apr 10, 2017 at 06:44:14PM -0700, Eric Anholt wrote:
> >> This is needed for proper synchronization with display on another DRM
> >> device (pl111 or tinydrm) with buffers produced by vc4 V3D. Fixes the
> >> new igt vc4_dmabuf_poll testcase, and rendering of one of the glmark2
> >> desktop tests on pl111+vc4.
> >>
> >> This doesn't yet introduce waits on other device's fences before vc4's
> >> rendering/display, because I don't have testcases for them.
> >>
> >> Signed-off-by: Eric Anholt <eric@anholt.net>
> >> Cc: Gustavo Padovan <gustavo.padovan@collabora.com>
> >> ---
> >> +static void vc4_fence_release(struct dma_fence *fence)
> >> +{
> >> + struct vc4_fence *f = to_vc4_fence(fence);
> >> +
> >> + kfree_rcu(f, base.rcu);
> >> +}
> >
> > Unless you have a plan to do more here, looks like you can just use
> > the default dma_fence_free as the release callback.
> > -Chris
>
> Yeah, this pattern came from etnaviv/msm (which I had used as
> reference), who both put their .base second. I wonder if they would
> want to flip the order of their fields and drop their fence_release,
> too.
Sounds reasonable and gets rid of a bit of code.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-04-12 12:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 1:44 [PATCH 1/3] drm/msm: Expose our reservation object when exporting a dmabuf Eric Anholt
2017-04-11 1:44 ` [PATCH 2/3] drm/etnaviv: " Eric Anholt
2017-04-12 12:47 ` Daniel Vetter
2017-04-12 12:54 ` Lucas Stach
2017-04-12 17:32 ` Eric Anholt
2017-04-11 1:44 ` [PATCH 3/3] drm/vc4: Add support for dma-buf fencing Eric Anholt
2017-04-11 9:35 ` Chris Wilson
2017-04-11 17:43 ` Eric Anholt
2017-04-12 12:49 ` Daniel Vetter [this message]
2017-04-12 12:48 ` Daniel Vetter
2017-04-12 17:33 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412124904.4f7bot45rcesqnrz@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=gustavo.padovan@collabora.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).