From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751639AbdDMKd1 (ORCPT ); Thu, 13 Apr 2017 06:33:27 -0400 Received: from mail-co1nam03on0085.outbound.protection.outlook.com ([104.47.40.85]:14752 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750746AbdDMKdX (ORCPT ); Thu, 13 Apr 2017 06:33:23 -0400 Authentication-Results: codeaurora.org; dkim=none (message not signed) header.d=none;codeaurora.org; dmarc=none action=none header.from=caviumnetworks.com; Date: Thu, 13 Apr 2017 13:33:09 +0300 From: Yury Norov To: Adam Wallis Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Peter Zijlstra , Catalin Marinas , Will Deacon , Ingo Molnar , Jan Glauber , jason.low2@hp.com Subject: Re: [RFC PATCH 0/3] arm64: queued spinlocks and rw-locks Message-ID: <20170413103309.GA1875@yury-N73SV> References: <1491860104-4103-1-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [89.179.247.55] X-ClientProxiedBy: DB6PR0501CA0041.eurprd05.prod.outlook.com (10.168.78.155) To BY1PR0701MB1270.namprd07.prod.outlook.com (10.160.108.16) X-MS-Office365-Filtering-Correlation-Id: 150a598f-62ed-4456-aa25-08d4825880f5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:BY1PR0701MB1270; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1270;3:WzMxOYhZSZX/wuU7AQsfbi15ZJ4SuoMqy5VhoYTqIn1u9V5paiWOl+kfLa4Sb+l0PIbzznhzZfQs0bSnHr74GMz5ooz5hBa8+a2NJnn2zEoDr7s0VaimsJ0i2tU2hJ4T+7akrLS9f3n98+a/OQt2GEM06dFI2qV1bwL1uqdmI7DymyNdpFeB2gbwcNiWcMT5ColbqmLaZK7DSm0FXA9NgP6L3mikQDNF+vfjZsy4V60OztEljzEeS61kf4EOj5pPIr/l+RmNldUnlUnzz0uThrsBFkz46Ih9B6ma6N9e2F+RVfr1eomuU2Vdz8O/9MVGr2HxnrO8Pk8BFp+QsgoPZA==;25:+n9+fQCi4yxJkaN0GU1QJK9NLaLMY1PFkSMsuRZZ5GeNPCv1DUKdes3GXCTVXr0td9A88RK+awA/5gZagcnpwJbD08Lq4EF0Cd/FyEpFfOqWZHeUiahZ3X5RdZQDT5rTLBCVLqzUo7wYrSEC/nDKNzPzfcE3NXf++FQtabpT96u5FXoHv+3DlK1zKRLqb0ymqOpcZg580UU9SBSKXn5tJpmgbu4CIWSm0911Oi7OibdVP4Ws1PehAeMFK15MoFJbYnfu9kIJ9jR8MWWO/Ae+aU8HopNWhHDTxXPdw4RWr0zv2T+KTuIH75a8cNcNV5hcbg7tNWPKOTN+eOLBUbumI4Xx012lPTsHCnDxXAqulm5yj6jf8N8MiGTyK3s2nJdsExIsHqYlIuMwAiE51MdRJcEmhQDNv/pjdgEPdr6e/lm5p0ngScMCd4Oc6fN3V5hob7iHhVnCTrWoZTG20u4HjA== X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1270;31:mJQjsDuPudG5dhL4NBOMGEjDMAiLOI2vSNEHQY1dTM7ipwmMNCrWFcn/sL7MGHs9orAN1F5w9SSlxeaEiAnFPf9TkkNrovDc8dLzYLPcTh/YQdlXogeZ+McBVBClnyVtscAF3OPmE/iU3nJVFT106BvurUl7zGihJtDNMNqobBIe8WBhCMBNvXT2RlI9PYcEoQYwOfjp5gi6I+OgUhljuOWe/3HOhtbZJi/Ji50llDD9BBJtPKjZHCz+LrPM+/lg;20:FmXrCoNTOl5d+c4Zsf+GgIvLyZLDlu8Y9jfTPjOr1Y7XkQcbwAgq3ItOZOnBFLrUoO2AMye1Y7Uggwg4rBNyrauynbCOW9aZd8yOiV/F454tiUkB+VU+MnL1Y6twBIoQ1hyhYs2IZdDQiPyNtL7wMEf17ONVBiLjiyop2DQBuZ9mRiaThbds535jPb8XeJ+fCZb1LmkmbpoFog/FOVmtcYTfB6APKIIMWO0ezrilDIoi4IuRzWR6kbVt9Ze7YUzW94/TLP5DOVUWW+T4c3gC1+5o0L+njJ291MU4cwiCtEBhuy2PuVQdiTHy5YusnqGS66RgU19YiVV6+Wh8C6Vsl0whKK1fi8xsRcKnVg1+E956IjJmM9DD3145x0vLJxr6pPYUD2uhiA1qiLKO8QDpx95fVrGKWMfedh+LWS13YosyhljTWwHTmmssjwB3ZXOkDhpiMlAodovp98ztnpV0ytYgsnavy5TCoCdFJIZinjksJyvuN+t3I25LJdQZMZinsNa614WAAn5OKKc0EWBbFaozU3F1WkyKXYNZVfG3iVAZwIS93XNN09P8sOwL6wnbtmwggTNuoXomBwBJSyIm225AzTwayUnNGe73JHIpHug= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148);SRVR:BY1PR0701MB1270;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1270; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1270;4:/upkgIFAoQY0qsPdEhEFQZ0AuwPYOkQjua0M1wXcaNNnibziLY5/+kXE/FUlPgy9z+dLX3ju9YoqIou8doPt+AC6MVgiPOCRDIJ/fsoeQjfss/ltdpHh3iFg9zbWF/l26u9Fuzw1SIQT9kJiVm9pQqckgBWGkEZGk4wuxg8kzvlKFTuY+TG9ZS85qyDVZFB1MU3OH6BAImxOfEHJ/RicsbfpuwJLo8UICFmNpDke3TKK66gLEMK7slISNqCRTqi47rOpZL73+glyi0tCkRfz2Yr2tbB4WYLRdCXfqaEIl5iO4d+4XZH6i/UJGjBSjyaGPLxjpcF2quBIvnkbOJZzgfvZ8B9wSS8YzWyOQ4UwBDugmpIIqpeQlgo7cK6EQc9RWJIzhvz1mJSuF6tO/tzZKOqzupfAqz4m/Y6R6KfZKIstB7bffsR2ZTx8+Jszq4rCeesKRU5vSYth2dGnIPPt0J5INQSHFZdXGjhBLLys+svPqPrLstVSTlvn5zb1AgyWYTLinERPotBlrw00LQzSvFeUaoMwm+zeUkzfOYgSBHaigm6ylJaRF5QfDB+IxbkyVZdJE9Kc653lQUTSUyCeCNcoxdumUgHvpX/N6wgseEomzkTy/zG3tFiIHru87bqvfmyvc8L++vGXs8dBebZHoAw3pNn08t2IcKZr+YzdqeHI16HRCPbvIr+w2io6jdPVl0nkf6oAkiXSm0AmLkoxtA== X-Forefront-PRVS: 02760F0D1C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(39450400003)(39850400002)(39410400002)(39400400002)(377454003)(24454002)(229853002)(7416002)(25786009)(83506001)(53546009)(6496005)(6246003)(110136004)(5660300001)(38730400002)(23726003)(3846002)(305945005)(6116002)(7736002)(4001350100001)(4326008)(54906002)(8666007)(189998001)(53936002)(6306002)(9686003)(47776003)(50466002)(66066001)(50986999)(6486002)(42186005)(76176999)(33716001)(76506005)(54356999)(33656002)(81166006)(8676002)(2906002)(6916009)(2950100002)(6666003)(18370500001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0701MB1270;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR0701MB1270;23:31gV8ltOAYcDRuL5PPJbsf0pFSnu9yVi5IBkJs7?= =?us-ascii?Q?X/Qpp9Nga0ldBVjhMi7AKNcRuXRscSWFinqtqJA14/tp1H5twX7MtJW22pdV?= =?us-ascii?Q?xThgXZQ9Z+soPbmpKMJOl7qQcXcKUDXAX2eQ62EUC//CdD2KiPEUV6j+4hJn?= =?us-ascii?Q?nbP5NslWc7NRqdV9mzM/FVdmyh8RkLHyqaya2jdFLQivM++226u7KBE2fIdX?= =?us-ascii?Q?MTTvlwgH6JXcZjefZnj6XXeMAPtVQLaRcSijRwLzZ3ZhB/B/FFxElWzbpGQb?= =?us-ascii?Q?Yh6ESdbVlcANM2IobUiczyDl6hXyCgLsKSh+4Hb/Cl8uLit7u9L6Vsxt/Azv?= =?us-ascii?Q?l9e/E6hTNH9BQ8m+f4qqoDByxhcOWYoj0gNa6KRF9oLaNffkP7+Yo+lRjRK8?= =?us-ascii?Q?GBUF2RgBw6+EancQ3e1n63uwpHv9fYmxCpk/T7eKJ9ahbn0Sa6jrnI7qdkt2?= =?us-ascii?Q?1gwb4tO8M2OvZlYQtTZZ4H18vWDnd3kxe+ufR1w7OqFdXRdoDWi33UiWw+uR?= =?us-ascii?Q?P6VLStHE0N2vJAn1J5pRUMUIH4S74Bo4WdlXH31SAJIm1lWLEwJljmPR1302?= =?us-ascii?Q?bOHpEUqa3G5K04e2qytCcFZehiRsqhtcsNGsRofP1xf4FgswSmmHGQygL+XB?= =?us-ascii?Q?VqqU8x9Nbb/z3+75xcHXS1ra0B2S/vUM9u/5XDVIrtqE313h2V8KgMjBPNKH?= =?us-ascii?Q?epcujG6r5gBq1R98pQlKwoeJ9AWlapzA+6eLMG/QcE/Pt2JAndClR7opqLJW?= =?us-ascii?Q?fkhmM+i7UNl0n4Fod+jcxEMK6tMHFCsQS3B5M098y4aYj5lvd1dPujVSpr0g?= =?us-ascii?Q?CpXGCt9S4Z0IC2UiM9levWVd8cwTRwQuXd1m47eGRIFPW0OE3RKgXrqD73B5?= =?us-ascii?Q?1Pp5AprschciAn0i4IOrPqurOGpzfV8qhqWsmG9o2+qFnYPwwILrBJe73os0?= =?us-ascii?Q?6PExW4MYcayG3Mt9F72ahPCIs/GtXLAQZuQESXinE8oj1rCaDkEZ5NLv5WXZ?= =?us-ascii?Q?ozwNTNinYMPh0JxYsY7JN0hJUHbYnFEePiaVMBnPuN3IUV5sKXMZsP7pR0TD?= =?us-ascii?Q?ynhh26Sbuvd7AYDWdT55MBzjf9OaYi9qo772XNG57jv9/7eu+MfPaOZewB/P?= =?us-ascii?Q?KCpI5TfV7MGjPHGhMIXCL6t/fnHV9n49GnU+gu2eVVhTpnW94oA6P7B1Vd0I?= =?us-ascii?Q?EApOuWaTbjnvqyPdjuixSzGTVxKfy7bNswZuv46UprKpGR/JjpH1OMOFfRAq?= =?us-ascii?Q?6p0gokHRCZIIBaAw5AQI=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1270;6:kflwSr9kQMJt1caQJ/HR7uTEDOm7YhWhA+XzD2uRfJjLKQCc7hHQNOCZfKR4gZIfGX378e3Rma+3izhchmaidCFAXPVpRbjRciAzAMUtnx7iDZf/ARbPXwUkSHLG55S2FCHNz96eOhgRgT1+AnBFlU61KoUcnim1jviHA4pWwcKh95Zi27rRHiXnUQuqk9Bef1UZerbopOU2kUJ9C2daFD7shg2zQZWzMsmHq/RrN//zD2/WhEwXlwUZRX4yIJdTGkWJ09OeEgM+AB1/LVHqk35eKkrDnAOXUhNHYYqVU8bDpg6HzR6nGzF2jjXL5kGtTRHEN6dVVdYts+LDu3/By4B8PRqf/DsVvjzL9L476KeS9qM33+B38DkutwrHg9NrZOo/WaMEFoZXjEzJD9DZ2uOSb9PrAzKIL7/MgmX5pGJaT/vdqW3lD/IJ+WKO7SwAfU9QnfwtgeLtUSORpBPlzg==;5:yDXpyCwsFAbpqOlLSA8VrNDQsDipYemfloVHB39iIu4SuZ1+c656EKJgTX5SBoND5NrD98MtuCjn5HMHR0yJ6GnlxchSBAv5V6lS9xVIWoHs+kxjSuTM6xrM8RXapw0/VoAF9++XVxP9cFIBoBIDmw==;24:J1nwTYFxU86xZ7MCh7041zHkMBgVnHNE1lkY5MSAMX9gp6Y/KOSePSrMXFDgZfcv8gPID0AEj7YzpWVm+sGkjb1S5rLzWx30t3+Vu568pN0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1270;7:mH6T1cgOcnY87yPcBGeWxKx9X8tVaXQk34+X/0oCOnDXCJ7u/7pvVMlEvhn+/s9Na+KpLWmU2bibVMPfNH9Zqbxq3xQLU4kqq0y4Q5d8dZs8t5+tWtv70yuBU/qVWhxwyXKCE88JYuhTxwRBx8skaxVPhkLwyLQcCaZoQ0RDB6YUXYE8PeNZ7YFSy8hPuGM/dsM3N2lne/4Me+6FCvI4fY61n9nGjnWfkM/YY7WgjDjheWpGx3Nx2VE0uwAe0qJJPoNHMnjWljtXHHsoQcZitfobhbAbhSHFx2eQgUJBMD8/cLN93GsRf7FlZwv0CMghQNoW3+W7wGIA5Uf7lVRleQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2017 10:33:19.3711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1270 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 01:04:55PM -0400, Adam Wallis wrote: > On 4/10/2017 5:35 PM, Yury Norov wrote: > > The patch of Jan Glauber enables queued spinlocks on arm64. I rebased it on > > latest kernel sources, and added a couple of fixes to headers to apply it > > smoothly. > > > > Though, locktourture test shows significant performance degradation in the > > acquisition of rw-lock for read on qemu: > > > > Before After > > spin_lock-torture: 38957034 37076367 -4.83 > > rw_lock-torture W: 5369471 18971957 253.33 > > rw_lock-torture R: 6413179 3668160 -42.80 > > > > On our 48 core QDF2400 part, I am seeing huge improvements with these patches on > the torture tests. The improvements go up even further when I apply Jason Low's > MCS Spinlock patch: https://lkml.org/lkml/2016/4/20/725 It sounds great. So performance issue is looking like my local problem, most probably because I ran tests on Qemu VM. I don't see any problems with this series, other than performance, and if it looks fine now, I think it's good enough for upstream. Yury.