From: Steven Rostedt <rostedt@goodmis.org>
To: Alex Shi <alex.shi@linaro.org>
Cc: peterz@infradead.org, mingo@redhat.com, corbet@lwn.net,
linux-kernel@vger.kernel.org (open list:LOCKING PRIMITIVES),
Sebastian Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio
Date: Thu, 13 Apr 2017 12:15:30 -0400 [thread overview]
Message-ID: <20170413121530.394c6ca8@gandalf.local.home> (raw)
In-Reply-To: <1492092174-31734-4-git-send-email-alex.shi@linaro.org>
On Thu, 13 Apr 2017 22:02:54 +0800
Alex Shi <alex.shi@linaro.org> wrote:
> We don't need to adjust prio before new pi_waiter adding. The prio
> only need update after pi_waiter change or task normal_prio change.
>
> Signed-off-by: Alex Shi <alex.shi@linaro.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Sebastian Siewior <bigeasy@linutronix.de>
> To: linux-kernel@vger.kernel.org
> To: Ingo Molnar <mingo@redhat.com>
> To: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> ---
> kernel/locking/rtmutex.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
> index 05ff685..3ee8bc1 100644
> --- a/kernel/locking/rtmutex.c
> +++ b/kernel/locking/rtmutex.c
> @@ -973,7 +973,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock,
> return -EDEADLK;
>
> raw_spin_lock(&task->pi_lock);
> - __rt_mutex_adjust_prio(task);
Yeah, I'm not sure why this is called here.
-- Steve
> waiter->task = task;
> waiter->lock = lock;
> waiter->prio = task->prio;
next prev parent reply other threads:[~2017-04-13 16:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 14:02 [RFC PATCH 0/3] rtmutex comments update and trival fix Alex Shi
2017-04-13 14:02 ` [PATCH 1/3] rtmutex: comments update Alex Shi
2017-04-13 15:54 ` Steven Rostedt
2017-04-14 8:52 ` Alex Shi
2017-04-14 18:43 ` Steven Rostedt
2017-04-18 8:38 ` Alex Shi
2017-04-13 16:00 ` Steven Rostedt
2017-04-13 14:02 ` [PATCH 2/3] rtmutex: deboost priority conditionally when rt-mutex unlock Alex Shi
2017-04-13 14:23 ` Sebastian Siewior
2017-04-13 14:39 ` Peter Zijlstra
2017-04-13 16:09 ` Steven Rostedt
2017-04-13 16:21 ` Peter Zijlstra
2017-04-13 16:40 ` Steven Rostedt
2017-04-13 16:51 ` Peter Zijlstra
2017-04-13 14:02 ` [PATCH 3/3] rtmutex: remove unnecessary adjust prio Alex Shi
2017-04-13 16:15 ` Steven Rostedt [this message]
2017-05-25 5:26 [PATCH v3 1/3] rtmutex: update rt-mutex-design Alex Shi
2017-05-25 5:26 ` [PATCH 3/3] rtmutex: remove unnecessary adjust prio Alex Shi
2017-06-20 0:40 ` Alex Shi
2017-07-07 2:52 [PATCH v4 1/3] rtmutex: update rt-mutex-design Alex Shi
2017-07-07 2:52 ` [PATCH 3/3] rtmutex: remove unnecessary adjust prio Alex Shi
2017-07-11 14:39 ` Alex Shi
2017-07-12 14:14 ` Steven Rostedt
2017-07-12 16:35 ` Peter Zijlstra
2017-07-13 6:13 ` Alex Shi
2017-07-13 6:12 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413121530.394c6ca8@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=alex.shi@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).