From: Rob Herring <robh@kernel.org>
To: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
christian.gmeiner@gmail.com, linux@roeck-us.net,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] input: touchscreen: ar1021_i2c: add support for AR1020
Date: Thu, 13 Apr 2017 15:35:32 -0500 [thread overview]
Message-ID: <20170413203532.thktt4yhqsg34cvc@rob-hp-laptop> (raw)
In-Reply-To: <fd7e784f-824c-1fff-4978-858c11971999@ginzinger.com>
On Thu, Apr 13, 2017 at 08:38:39AM +0200, Martin Kepplinger wrote:
>
>
> On 2017-04-12 17:40, Dmitry Torokhov wrote:
> > Hi Martin,
> >
> > On Tue, Apr 11, 2017 at 12:27:57PM +0200, Martin Kepplinger wrote:
> >> ar1021_i2c simply also supports the ar1020 device we use. This is tested.
> >> They also share the same datasheet:
> >>
> >> http://ww1.microchip.com/downloads/en/DeviceDoc/40001393C.pdf
> >>
> >> We differentiate not only to make it obvious that we support both devices,
> >> but also to be able to implement the few model specific things in the
> >> future.
[...]
> >
> > I do not see where you handle ar1020 differently from ar1021. If devices
> > are compatible, you do not need to add a new compatible to the driver,
> > simply use it in the binding:
> >
> > compatible = "microchip,ar1020-i2c", "microchip,ar1021-i2c";
> >
> > Thanks.
> >
>
> Why would you use "microchip,ar1020-i2c" in the dts if it's not
> available? people don't obviously see, by grepping or reading,
> that they have a compatible driver. ... or did I get you wrong?
>
> I don't handle anything differently now. Factory reset has to be done
> differntly though, as one example. So it'd be nice to have the option
> to add data.
Having both lets you use the current driver now and you can match on the
more specific compatible string when and if you need to. That's exactly
why we have multiple compatibles. I could imagine the driver never
supports factory reset. Add both to comments or kconfig help if you want
to make it clear that both devices are supported.
Rob
next prev parent reply other threads:[~2017-04-13 20:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 10:27 [PATCH 1/3] input: touchscreen: ar1021_i2c: add support for AR1020 Martin Kepplinger
2017-04-11 10:27 ` [PATCH 2/3] Documentation: devicetree: bindings: add bindings doc for ar1021 driver Martin Kepplinger
2017-04-13 20:40 ` Rob Herring
2017-04-14 6:11 ` [PATCH v2] dt-bindings: input: add bindings document for ar1021_i2c driver Martin Kepplinger
2017-04-20 13:40 ` Rob Herring
2017-04-20 17:42 ` Dmitry Torokhov
2017-04-11 10:27 ` [PATCH 3/3] input: touchscreen: ar1021_i2c: coding style fixes Martin Kepplinger
2017-04-12 15:41 ` Dmitry Torokhov
2017-04-12 15:40 ` [PATCH 1/3] input: touchscreen: ar1021_i2c: add support for AR1020 Dmitry Torokhov
2017-04-13 6:38 ` Martin Kepplinger
2017-04-13 20:35 ` Rob Herring [this message]
2017-04-14 6:02 ` [PATCH v2] input: touchscreen: ar1021_i2c: highlight " Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413203532.thktt4yhqsg34cvc@rob-hp-laptop \
--to=robh@kernel.org \
--cc=christian.gmeiner@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.kepplinger@ginzinger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).