From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbdDNOIC (ORCPT ); Fri, 14 Apr 2017 10:08:02 -0400 Received: from mail-eopbgr50104.outbound.protection.outlook.com ([40.107.5.104]:42301 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751544AbdDNOH6 (ORCPT ); Fri, 14 Apr 2017 10:07:58 -0400 Authentication-Results: zeniv.linux.org.uk; dkim=none (message not signed) header.d=none;zeniv.linux.org.uk; dmarc=none action=none header.from=virtuozzo.com; From: Andrey Ryabinin To: Alexander Viro , CC: Andrey Ryabinin , Konrad Rzeszutek Wilk , Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , Steve French , Matthew Wilcox , Ross Zwisler , Trond Myklebust , Anna Schumaker , Andrew Morton , Jan Kara , Jens Axboe , Johannes Weiner , Alexey Kuznetsov , Christoph Hellwig , , , , , , Subject: [PATCH 0/4] Properly invalidate data in the cleancache. Date: Fri, 14 Apr 2017 17:07:49 +0300 Message-ID: <20170414140753.16108-1-aryabinin@virtuozzo.com> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: VI1PR08CA0039.eurprd08.prod.outlook.com (10.164.95.49) To HE1PR0801MB2732.eurprd08.prod.outlook.com (10.169.123.152) X-MS-Office365-Filtering-Correlation-Id: dc088de7-99a4-458b-7dc3-08d4833fa48a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:HE1PR0801MB2732; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2732;3:FkVDxOcXmoT3OQkWJOapo8xH9KDaOTkQe9vRh8lPnao0VrgLOP1Lo1XfNwi0xb05R+C7iIeA0PahlhSFh2DxPyKCAM1E/QU7WgtdvZvqehM/NmK+ewJU4xZU76a9e+XCXw/MZr/XLrd9ccOMA+W7p17tPEHcIc0sIBqgtOg7swlTK8yDCQNwp8UYFGOTPnGWGsWtFfJS2hQk27qKpLKlNaC5hHkf6fFsuUFiGSAE8WGu69h6Hk0ZcBDcAjdDNuHHu37PztumX6rWPA0TlfKrH6g4iVNGlOxkAsYoZ/CMCpZXMNw7AwDyzQsz3uTRZHwDCMmu7MXDu4Biq6Li3DtwpA==;25:gj7YhXyyHIxz/fByidEKH/iOvv0royzNS5cXkMIWNapFKvwdyvsw1o6zoGf8hutVP21z/Ji6egdhoGuJY5uQT8BtEmQecsP7vpLN3nEo4k0RXmnG06b3d+rX/XqMi+79Tov/o49ZYYHbuFvYHkqNUlcQZbmZJ69mE49bN0meIXJIftGv/chOOp8YsdrWabUROIqkxYgGS7oBBIYpOGG8wBta4k4lUZAvUvo9/fK8RLzSKuWWw0fvQ95k8qJvKTN6EI///k6RBvl1cRIwGkQZ7IHi0vFerpKYSWgT1FCdiECSQTaidvGLwxTsuv4CT/9LAcaOquia+gZut7Exir5w6UbvABbcQXY7t/f94bExsgTuqwjs3bFhpGq44+ND0Pudiu5oDif5q8ay10UuEahf8SNI29KHoa65qsGIkvjjBrw2U0+XEwhDbxuLHtVmp3MTeRzGuuQFVG9ZyPi4yba3Og== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2732;31:eQxuOceqo50DYhH1BKuSpXfVBp+IMfPEY3jlrTRk4D2CjlR565RAIGdR93zbTaRBaOIPc+NLTABjXqPTF7PaHTPIypk09O0wwkMPErbvUfnnYk74oB778PabwS6b61OoKmmBmMxW1t8LisrhseHJFjtPIoVyFRvYkyri0nmUp5saBDShyNVxdxX1CJmLiHSLEyp7xw40IwKNj8JZsDQGxgbgTsffXZBwsW+wrfR6N/APe0gGM/QZ5hIjpVf6yorW;20:WjyD2nj7YD/DCj8hCHej32lczzNlFs3qpCpYltWF9OziS6pYyS/WDE7dciqRgKtc/z1l4fkGwJjfZz2ux7Hkd8o7ScEevhc9xa2G4hvjFIBYz4sipNCvJzla6f0o4cGB7i6Fnk/FGiPf6p8Rsn3VvGen+XZk3hUuRJEDikRCggLRgg9RwQB9MNkimwhaSAuhhMlyBx3kSVfcfw+AwOQxGvPsbA9Jhb83wz2/46Icg/kvTClLvdV3K2TdACxA3E2l8mejPCbq4f9BMviaRDIXWLAX6h6cDZ3obkYwG6v4YCu9xyCu+P/kEy+5bJZxL1LnPypCOsYKCxNMzkE5ft7e4773yv6y3MylYMfZR5/FjGCnjeX2TxQnwXpH3XrbJJQoNeRO2HbxAhy37MLgndyf2Id8Mf1c5D+UWxNqhntSRfc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123555025)(20161123562025)(6072148);SRVR:HE1PR0801MB2732;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB2732; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2732;4:D18HnXsn2Q//yyft0t1LpPpY36vStn2CNhd/3FmUTzRCpWFLDlnsCdSnW9DLxKn9ilrrU2Ke7qwyqoySUSlROwdSNd6wRDPzMqnJRNHgh9Qyki58wYQ1h1Z8HytcZvjRQDu7hhDUabzY9cMDCFdHcLQlwEVUAPf7WiyXr3kYEwdLZBR0bGpwYSRdUyo0imITnf74ckeAC7cYTWhSkk8v31TPzqSUUt+mm6Q85+DR5BntdirBpyW57vxwaGbWsmGniPf7fT12BI2ym2I4gn2xv2eba3HQvLb5ElOoiq01e1lYVFiwgfLSGXd/q2K/RdroMcijj9ezPmiaY3wJOZUIFenYWN7UANcXcEX7QH7PICn8H35kKQPhQZFKyOR6ekSFdJZVUTFmvN5B/Um2lP4Dvv+edeSJ//SgrPhEqHJIMU8DJ/1V7GDUvskNf0j1hBD9CTCLBk7qh85/LjfrfQGkZ8ruYGhAo2ZjgbfDCrVGxqwzRCYmGWQtQneyx3RwNqn8wSaY09NYq1rCDi1jz5icrtrsr2h8XEB1tKczICDgvem4CewBHOM37c0+cDmabra09QNfAGqryJDCCHXIffxvuWk6wFi2zAY/9/m+sWF/gCRZRZN/0sfRImL3JB0A5+utvxc/T6Ocff0Ohta87t8NJL7rDrYsHSgwFYSiQtX9J8JPGPNBJqhBn8XwQcv+deS84cew5bmCfz1wkatBBsx20g== X-Forefront-PRVS: 02778BF158 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6069001)(6009001)(39410400002)(39400400002)(39830400002)(39450400003)(81166006)(6486002)(86362001)(54906002)(7736002)(305945005)(50466002)(66066001)(47776003)(5003940100001)(50226002)(48376002)(1076002)(33646002)(53936002)(5660300001)(4326008)(6512007)(50986999)(7416002)(25786009)(53416004)(6116002)(3846002)(8666007)(2906002)(36756003)(8676002)(42186005)(6506006)(189998001)(38730400002)(76506005);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB2732;H:localhost.sw.ru;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0801MB2732;23:r5SMg5rnNnTr/gmBwUP1MfK5yNMJAf7cT/exa3T?= =?us-ascii?Q?TMiCrhldk8okU3JbCGzBHNBcovkRq/X4MmMsZvfyBfruDt0w9bLmJLoUP65d?= =?us-ascii?Q?fPxFCQy1rETlY0F8RTxNwOj1+LXKUz8uxSdRfvH4T7ylqR+DRTcAg4knxorF?= =?us-ascii?Q?huO6c/ffdKMUBoFedqu4jUz0i7sKBG5PgoXG64w/C1hf0Uxs025nUPSJfRdh?= =?us-ascii?Q?LDbWakKwAM8SWljFBrb4cUU+rZiWO8Ugh9iuUV0cezKsAvWb5goyXvLTNgY/?= =?us-ascii?Q?aHbDz0pKj2LaNX2sr4LpRIxkvUKkcTp/F2IQW/zishfZuyV+2WlP+KsUnbhf?= =?us-ascii?Q?66qld38d381t0MSWgAEFKyRBQvbqx+GDfG7c9izHkTI8NsZ9Lzln9d0G/Imq?= =?us-ascii?Q?b4+3SG564P9DRkyResydjRObPphXtcYYnI9mHZKueL/MGsc+K2ESFy3LfEEQ?= =?us-ascii?Q?VxisK+/90u1GeFko0Zhi4ikiPxpdMvNvfruLz3fFA1L4YW2IeTq8uchDh1+d?= =?us-ascii?Q?CAFCA32fw62QytsZFBrB/KHY0oC0EIUG/ZriS++0LgZXEzdAIlFmMP81R2in?= =?us-ascii?Q?R+9rqOfo8pQjywUe1hzO2bmvQdy66zCkzKictOT4qE0Wm0HhKAlAZZ1SYDS9?= =?us-ascii?Q?jW9ECZQEojxXPBK/qaYwA5jwMy6xC0sz6W2Lawcf/cD1qZu/dy9eG0ZoD011?= =?us-ascii?Q?8LrX1QjBCHt70d+Zn/9vmYskDzBVQN9AV2rpJV4tpxhkez8t2Qfw7lJyOQYl?= =?us-ascii?Q?FwIBZzEIVS/DHmoCTIDf0zElBOAuAzr+3ORpr6jLtgGweNzpavRg0d8SsUJf?= =?us-ascii?Q?coMftUJO6pJ5eZUl3SuwwrBFM8J0dyRmQrMu4BIHTRHZvI8vpuVs2mWzGOBm?= =?us-ascii?Q?OspjqNt6R+8fSItew9+9EqSbh+7SH/8MFr9Z/RgFKWgm9LLxiVuSxjiVH4Z1?= =?us-ascii?Q?KaMWb4AeizVu3/FATcxMrvHLOj6snBthaENfjHWyAuaPbFv6vtM+HGRozLHZ?= =?us-ascii?Q?bpJmu8BvLcaxbxEkf15plQY6j?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2732;6:rObO3WEJrmbknMe+deYVZQg9RO4LSEA3dAcPNjibTwjIkH2NVk2dN9Gkw1T8Y9Ry2M3LfExV+uGfq82FhZYs/AoD6QFXO5RbkoDT5Qnh5V1x0t6bwYUPI3uJysJI9Z1Qxd/ZTqhSGUYvzxKhtKN0m1e5EFUi1iZQs2HnpjWbKBBSsu/AnDWzHLBz67rwumW3W3IsIwZNOwCljIYjb8PSstp/KOuwLSx3+m94WMYstxAsHXQRuGom9P3GWkj7Z8PHwka/kfSbM4kTCWs6Wsg8fFTsLHfc4yCyy33UuMHKuvNE/CNyzmVHM9AEzZeM3ey8bA6lrdfAFo2Lo+btk2uikqTJu+3egtwShNe7Olmu5CBvbWQnGshNhXmapo/i6u8TqQ1cO9IK4r0u7Z1GSjYr5IotT+RRN6eNyuJPZMPI0D29nTSI1iwJZOMS/KzEGDqiNzPztm5N604G6OVUdK5VYQ==;5:+U/gbqK/7ojq5rbcBEBSRR8czQtjkTU7YE0WZuLcJQgZ97nJWg6GJr0pjUfnQdAp9EE58imn8RXyEWPccSZI07AkAJz4TxoUwQ158OVuVsjtNdLnAHCeMn9DSYBx8Q7nWJzgDOoR4R+x9sWpX1nASQ==;24:Svtbfe+yt1eYUj2ULWBQu3bEfpZwuw8sVga4SkHvV8cNwNSsMopg9pGTJnkjcL8SZAfwS1pdawLE9WA7c8E7tdSGZSj/G1gJU4hI7EaUJqM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2732;7:SnEWXz7dKmXqu+dj6xtz/pBPfNn2/qgn6lcatlradmspngm+c8UNHgcdkWSxA6s7nYbDDhAkipy8wlbS0V9tQiXGgve3QRlPDCGEeUNLgzVTRf7JXQXRBBcvcm7Ffk/Ito6Pp6N7PZVtSJ6b/G/dHZI203S6Pjcu0t1cCuHVHeUiJ9QtJaSXmKggHLjd4ZNwbWlW06d4dOVVhjHibpDpmJVKdG4uqZrMZqut5FWfI9zsWpVgDdr67AhqGp+QRmCF/KK7LX4UVyOUpo6+W6DCTl2+fWCgBb4Baj3Vec6+oiuQkvFeT7rRgZvN+WW5QYQT/77ESCj+T7CDH8K7oojgxQ==;20:dE8wfwko0soA19qelk3xEB1TWyk42U8mFTBZLXahoZHqsXsVPGdfBWr9L4zLodXfcnYYgaHL0teOTTYI2Pbz4goU93pYShFlnpYSCvnAyXMNjeKfN4c60GCQ/xfBQ+aNCVI2tJn89fpzLMst6DbWDJBglHOKOYKPDlhxK4+9/eM= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2017 14:07:50.6393 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2732 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We've noticed that after direct IO write, buffered read sometimes gets stale data which is coming from the cleancache. The reason for this is that some direct write hooks call call invalidate_inode_pages2[_range]() conditionally iff mapping->nrpages is not zero, so we may not invalidate data in the cleancache. Another odd thing is that we check only for ->nrpages and don't check for ->nrexceptional, but invalidate_inode_pages2[_range] also invalidates exceptional entries as well. So we invalidate exceptional entries only if ->nrpages != 0? This doesn't feel right. - Patch 1 fixes direct IO writes by removing ->nrpages check. - Patch 2 fixes similar case in invalidate_bdev(). Note: I only fixed conditional cleancache_invalidate_inode() here. Do we also need to add ->nrexceptional check in into invalidate_bdev()? - Patches 3-4: some optimizations. Andrey Ryabinin (4): fs: fix data invalidation in the cleancache during direct IO fs/block_dev: always invalidate cleancache in invalidate_bdev() mm/truncate: bail out early from invalidate_inode_pages2_range() if mapping is empty mm/truncate: avoid pointless cleancache_invalidate_inode() calls. fs/9p/vfs_file.c | 2 +- fs/block_dev.c | 11 +++++------ fs/cifs/inode.c | 2 +- fs/dax.c | 2 +- fs/iomap.c | 16 +++++++--------- fs/nfs/direct.c | 6 ++---- fs/nfs/inode.c | 8 +++++--- mm/filemap.c | 26 +++++++++++--------------- mm/truncate.c | 13 +++++++++---- 9 files changed, 42 insertions(+), 44 deletions(-) -- 2.10.2