From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Icenowy Zheng <icenowy@aosc.io>, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 11/11] arm64: allwinner: a64: enable Wi-Fi for Pine64
Date: Mon, 17 Apr 2017 09:59:21 +0200 [thread overview]
Message-ID: <20170417075921.vrjchymctxidtp7l@lukather> (raw)
In-Reply-To: <e51897d2-aa9d-1f4b-3fe0-e88246a9e438@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]
On Fri, Apr 14, 2017 at 06:56:16PM +0200, Andreas Färber wrote:
> > one provides I/O voltage).
> >
> > Add device node for it.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > index 7da074f95065..9d90bb32aa87 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> > @@ -64,6 +64,11 @@
> > regulator-min-microvolt = <3300000>;
> > regulator-max-microvolt = <3300000>;
> > };
> > +
> > + wifi_pwrseq: wifi_pwrseq {
> > + compatible = "mmc-pwrseq-simple";
> > + reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
> > + };
> > };
> >
> > &ehci1 {
> > @@ -91,6 +96,17 @@
> > status = "okay";
> > };
> >
> > +&mmc1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc1_pins>;
> > + vmmc-supply = <®_dldo4>;
> > + vqmmc-supply = <®_eldo1>;
> > + mmc-pwrseq = <&wifi_pwrseq>;
> > + non-removable;
> > + bus-width = <4>;
> > + status = "okay";
> > +};
>
> As you mention above, Wi-Fi is a module, so may be absent. Is it really
> correct to enable this node and hardcode a certain power sequence? In
> theory other modules could be attached.
>
> To me that calls for an overlay instead.
Agreed.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-04-17 7:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 18:34 [PATCH v2 00/11] AXP803 PMIC support for Pine64 Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 01/11] arm64: allwinner: a64: enable RSB on A64 Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 02/11] arm64: allwinner: a64: add NMI controller " Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 03/11] dt-bindings: add device tree binding for X-Powers AXP803 PMIC Icenowy Zheng
2017-04-11 14:04 ` Lee Jones
2017-04-11 15:00 ` Icenowy Zheng
2017-04-11 15:02 ` [linux-sunxi] " Chen-Yu Tsai
2017-04-11 16:29 ` Lee Jones
2017-04-13 19:56 ` Rob Herring
2017-04-07 18:34 ` [PATCH v2 04/11] mfd: axp20x: support AXP803 variant Icenowy Zheng
2017-04-11 14:04 ` Lee Jones
2017-04-07 18:34 ` [PATCH v2 05/11] arm64: allwinner: a64: add AXP803 node to Pine64 device tree Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 06/11] dt-bindings: add AXP803's regulator info Icenowy Zheng
2017-04-11 14:03 ` Lee Jones
2017-04-13 19:57 ` Rob Herring
2017-04-07 18:34 ` [PATCH v2 07/11] regulator: axp20x-regulator: add support for AXP803 Icenowy Zheng
2017-04-11 14:03 ` Lee Jones
2017-04-07 18:34 ` [PATCH v2 08/11] mfd: axp20x: add axp20x-regulator cell " Icenowy Zheng
2017-04-11 14:03 ` Lee Jones
2017-04-07 18:34 ` [PATCH v2 09/11] arm64: allwinner: a64: add DTSI file for AXP803 PMIC Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng
2017-04-07 18:34 ` [PATCH v2 11/11] arm64: allwinner: a64: enable Wi-Fi " Icenowy Zheng
2017-04-14 16:56 ` Andreas Färber
2017-04-17 7:59 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170417075921.vrjchymctxidtp7l@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).