From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754417AbdDQRaC (ORCPT ); Mon, 17 Apr 2017 13:30:02 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34624 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879AbdDQR36 (ORCPT ); Mon, 17 Apr 2017 13:29:58 -0400 Date: Mon, 17 Apr 2017 10:29:55 -0700 From: Eric Biggers To: kernel test robot Cc: keyrings@vger.kernel.org, David Howells , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , stable@vger.kernel.org, lkp@01.org, ltp@lists.linux.it Subject: Re: [lkp-robot] [KEYS] bdf7c0f8bf: ltp.add_key02.fail Message-ID: <20170417172955.GA31469@gmail.com> References: <20170401213428.17097-1-ebiggers3@gmail.com> <20170417062641.GN31394@yexl-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170417062641.GN31394@yexl-desktop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2017 at 02:26:41PM +0800, kernel test robot wrote: > > FYI, we noticed the following commit: > > commit: bdf7c0f8bf282ba44827ce3c7fd7936c8e90a18a ("KEYS: fix dereferencing NULL payload with nonzero length") > url: https://github.com/0day-ci/linux/commits/Eric-Biggers/KEYS-fix-dereferencing-NULL-payload-with-nonzero-length/20170403-102013 > base: https://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-security.git next > ... > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > user :notice: [ 45.447047] <<>> > > user :notice: [ 45.447365] tag=add_key02 stime=1492169102 > > user :notice: [ 45.447567] cmdline="add_key02" > > user :notice: [ 45.447685] contacts="" > > user :notice: [ 45.447826] analysis=exit > > user :notice: [ 45.448011] <<>> > > user :notice: [ 45.448568] tst_test.c:760: INFO: Timeout per run is 0h 05m 00s > > user :notice: [ 45.449439] add_key02.c:65: FAIL: add_key() failed unexpectedly, expected EINVAL: EFAULT In my opinion this is a valid behavior, and the test is just weird; it's passing in *both* an unaddressable payload and an invalid description, so it's not clear which case it's meant to be testing. (Generally, if a syscall will fail for more than one reason, it's not guaranteed which error code you'll get.) In any case, once we have a fix merged, it would be nice for there to be an ltp test added for the "NULL payload with nonzero length" case with one of the key types that crashed the kernel. Eric