* [PATCH v2] net: cx89x0: move attribute declaration before struct keyword
@ 2017-04-17 20:54 Stefan Agner
2017-04-18 20:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Agner @ 2017-04-17 20:54 UTC (permalink / raw)
To: davem; +Cc: shc_work, jarod, netdev, linux-kernel, Stefan Agner
The attribute declaration is typically before the definition. Move
the __maybe_unused attribute declaration before the struct keyword.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Changes in v2:
- Move __maybe_unused after the complete type
drivers/net/ethernet/cirrus/cs89x0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c
index 3647b28e8de0..47384f7323ac 100644
--- a/drivers/net/ethernet/cirrus/cs89x0.c
+++ b/drivers/net/ethernet/cirrus/cs89x0.c
@@ -1896,7 +1896,7 @@ static int cs89x0_platform_remove(struct platform_device *pdev)
return 0;
}
-static const struct __maybe_unused of_device_id cs89x0_match[] = {
+static const struct of_device_id __maybe_unused cs89x0_match[] = {
{ .compatible = "cirrus,cs8900", },
{ .compatible = "cirrus,cs8920", },
{ },
--
2.12.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: cx89x0: move attribute declaration before struct keyword
2017-04-17 20:54 [PATCH v2] net: cx89x0: move attribute declaration before struct keyword Stefan Agner
@ 2017-04-18 20:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-04-18 20:00 UTC (permalink / raw)
To: stefan; +Cc: shc_work, jarod, netdev, linux-kernel
From: Stefan Agner <stefan@agner.ch>
Date: Mon, 17 Apr 2017 13:54:34 -0700
> The attribute declaration is typically before the definition. Move
> the __maybe_unused attribute declaration before the struct keyword.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Changes in v2:
> - Move __maybe_unused after the complete type
Applied to net-next, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-18 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-17 20:54 [PATCH v2] net: cx89x0: move attribute declaration before struct keyword Stefan Agner
2017-04-18 20:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).