From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: clg@kaod.org, gwshan@linux.vnet.ibm.com, joel@jms.id.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/ncsi: fix checksum validation in response packet
Date: Tue, 18 Apr 2017 10:06:00 +1000 [thread overview]
Message-ID: <20170418000600.GA4978@gwshan> (raw)
In-Reply-To: <20170417.133619.1515025171498720534.davem@davemloft.net>
On Mon, Apr 17, 2017 at 01:36:19PM -0400, David Miller wrote:
>From: Cédric Le Goater <clg@kaod.org>
>Date: Fri, 14 Apr 2017 10:56:37 +0200
>
>> htonl was used instead of ntohl. Surely a typo.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>
>I don't think so, "checksum" is of type "u32" thus is in host byte
>order. Therefore "htonl()" is correct.
>
Yeah, "htonl()" is correct here. "*pchecksum" is in big-endian.
I want to know how Cédric thinks it's a problem. I guess he might
encounter the issue on the emulated NCSI channel by QEMU. On BCM5718
or BCM5719, the checksum in AEN and response packet are zero'd, meaning
the software shouldn't validate it at all.
Thanks,
Gavin
next prev parent reply other threads:[~2017-04-18 0:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 8:56 [PATCH] net/ncsi: fix checksum validation in response packet Cédric Le Goater
2017-04-17 17:36 ` David Miller
2017-04-18 0:06 ` Gavin Shan [this message]
2017-04-18 6:16 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418000600.GA4978@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=clg@kaod.org \
--cc=davem@davemloft.net \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).