From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753702AbdDREbZ (ORCPT ); Tue, 18 Apr 2017 00:31:25 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58314 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbdDREbW (ORCPT ); Tue, 18 Apr 2017 00:31:22 -0400 Date: Tue, 18 Apr 2017 06:31:10 +0200 From: Greg Kroah-Hartman To: Martin Kaiser Cc: linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry Message-ID: <20170418043110.GA30463@kroah.com> References: <1488234485-26111-1-git-send-email-martin@kaiser.cx> <1492453377-23796-1-git-send-email-martin@kaiser.cx> <1492453377-23796-2-git-send-email-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492453377-23796-2-git-send-email-martin@kaiser.cx> User-Agent: Mutt/1.8.1 (2017-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2017 at 08:22:57PM +0200, Martin Kaiser wrote: > Set the permissions for /proc/misc to 0444 explicitly. At the moment, > we're using 0 and have proc_create_data() convert this to 0444. > This fixes a checkpatch warning. > > Signed-off-by: Martin Kaiser > --- > v2: > separate patch for each checkpatch warning > > drivers/char/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/misc.c b/drivers/char/misc.c > index 3447b2e..3c633d5 100644 > --- a/drivers/char/misc.c > +++ b/drivers/char/misc.c > @@ -280,7 +280,7 @@ static int __init misc_init(void) > int err; > struct proc_dir_entry *ret; > > - ret = proc_create("misc", 0, NULL, &misc_proc_fops); > + ret = proc_create("misc", 0444, NULL, &misc_proc_fops); What checkpatch warning does this fix? 0 is a number :) thanks, greg k-h