linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Cc: boris.ostrovsky@oracle.com, Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 06/11] x86/xen: use capabilities instead of fake cpuid values for acpi
Date: Tue, 18 Apr 2017 08:31:14 +0200	[thread overview]
Message-ID: <20170418063119.11654-7-jgross@suse.com> (raw)
In-Reply-To: <20170418063119.11654-1-jgross@suse.com>

When running as pv domain xen_cpuid() is being used instead of
native_cpuid(). In xen_cpuid() the acpi feature is indicated as not
being present by special casing the related cpuid leaf in case we
are not the initial domain.

Instead of delivering fake cpuid values clear the cpu capability bit
for acpi instead.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 arch/x86/xen/enlighten_pv.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 53fe97bd720f..3196961862bc 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -165,7 +165,6 @@ xen_running_on_version_or_later(unsigned int major, unsigned int minor)
 	return false;
 }
 
-static __read_mostly unsigned int cpuid_leaf1_edx_mask = ~0;
 static __read_mostly unsigned int cpuid_leaf1_ecx_mask = ~0;
 
 static __read_mostly unsigned int cpuid_leaf1_ecx_set_mask;
@@ -177,7 +176,6 @@ static void xen_cpuid(unsigned int *ax, unsigned int *bx,
 {
 	unsigned maskebx = ~0;
 	unsigned maskecx = ~0;
-	unsigned maskedx = ~0;
 	unsigned setecx = 0;
 	/*
 	 * Mask out inconvenient features, to try and disable as many
@@ -187,7 +185,6 @@ static void xen_cpuid(unsigned int *ax, unsigned int *bx,
 	case 1:
 		maskecx = cpuid_leaf1_ecx_mask;
 		setecx = cpuid_leaf1_ecx_set_mask;
-		maskedx = cpuid_leaf1_edx_mask;
 		break;
 
 	case CPUID_MWAIT_LEAF:
@@ -214,7 +211,6 @@ static void xen_cpuid(unsigned int *ax, unsigned int *bx,
 	*bx &= maskebx;
 	*cx &= maskecx;
 	*cx |= setecx;
-	*dx &= maskedx;
 }
 STACK_FRAME_NON_STANDARD(xen_cpuid); /* XEN_EMULATE_PREFIX */
 
@@ -294,10 +290,6 @@ static void __init xen_init_cpuid_mask(void)
 	unsigned int ax, bx, cx, dx;
 	unsigned int xsave_mask;
 
-	if (!xen_initial_domain())
-		cpuid_leaf1_edx_mask &=
-			~((1 << X86_FEATURE_ACPI));  /* disable ACPI */
-
 	cpuid_leaf1_ecx_mask &= ~(1 << (X86_FEATURE_X2APIC % 32));
 
 	ax = 1;
@@ -323,6 +315,9 @@ static void __init xen_init_capabilities(void)
 	setup_clear_cpu_cap(X86_FEATURE_APERFMPERF);
 	setup_clear_cpu_cap(X86_FEATURE_MTRR);
 	setup_clear_cpu_cap(X86_FEATURE_ACC);
+
+	if (!xen_initial_domain())
+		setup_clear_cpu_cap(X86_FEATURE_ACPI);
 }
 
 static void xen_set_debugreg(int reg, unsigned long val)
-- 
2.12.0

  parent reply	other threads:[~2017-04-18  6:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18  6:31 [PATCH v3 00/11] x86: xen cpuid() cleanup Juergen Gross
2017-04-18  6:31 ` [PATCH v3 01/11] xen: set cpu capabilities from xen_start_kernel() Juergen Gross
2017-04-18  6:31 ` [PATCH v3 02/11] x86/xen: don't indicate DCA support in pv domains Juergen Gross
2017-04-18  6:31 ` [PATCH v3 03/11] x86/xen: use capabilities instead of fake cpuid values for aperf Juergen Gross
2017-04-18  6:31 ` [PATCH v3 04/11] x86/xen: use capabilities instead of fake cpuid values for mtrr Juergen Gross
2017-04-18  6:31 ` [PATCH v3 05/11] x86/xen: use capabilities instead of fake cpuid values for acc Juergen Gross
2017-04-18  6:31 ` Juergen Gross [this message]
2017-04-18  6:31 ` [PATCH v3 07/11] x86/xen: use capabilities instead of fake cpuid values for mwait Juergen Gross
2017-04-18  6:31 ` [PATCH v3 08/11] x86/xen: use capabilities instead of fake cpuid values for x2apic Juergen Gross
2017-04-18  6:31 ` [PATCH v3 09/11] x86/xen: use capabilities instead of fake cpuid values for xsave Juergen Gross
2017-04-18 10:02   ` [Xen-devel] " Andrew Cooper
2017-04-18 11:56     ` Juergen Gross
2017-04-21 14:24   ` Boris Ostrovsky
2017-04-21 14:38     ` Juergen Gross
2017-04-21 14:45       ` Andrew Cooper
2017-04-21 14:51         ` Boris Ostrovsky
2017-04-24  6:23           ` Juergen Gross
2017-04-18  6:31 ` [PATCH v3 10/11] vmware: set cpu capabilities during platform initialization Juergen Gross
2017-04-18  6:31 ` [PATCH v3 11/11] x86/cpu: remove hypervisor specific set_cpu_features Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418063119.11654-7-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).