From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755875AbdDRHvf (ORCPT ); Tue, 18 Apr 2017 03:51:35 -0400 Received: from botnar.kaiser.cx ([176.28.20.183]:56320 "EHLO botnar.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755816AbdDRHvd (ORCPT ); Tue, 18 Apr 2017 03:51:33 -0400 Date: Tue, 18 Apr 2017 09:51:31 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry Message-ID: <20170418075131.GA15328@botnar.kaiser.cx> References: <1488234485-26111-1-git-send-email-martin@kaiser.cx> <1492453377-23796-1-git-send-email-martin@kaiser.cx> <1492453377-23796-2-git-send-email-martin@kaiser.cx> <20170418043110.GA30463@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170418043110.GA30463@kroah.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thus wrote Greg Kroah-Hartman (gregkh@linuxfoundation.org): > > - ret = proc_create("misc", 0, NULL, &misc_proc_fops); > > + ret = proc_create("misc", 0444, NULL, &misc_proc_fops); > What checkpatch warning does this fix? 0 is a number :) ERROR: Use 4 digit octal (0777) not decimal permissions #285: FILE: drivers/char/misc.c:285: + ret = proc_create("misc", 0, NULL, &misc_proc_fops); Best regards, Martin