From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names
Date: Tue, 18 Apr 2017 11:04:47 +0200 [thread overview]
Message-ID: <20170418090447.dcxinewczubf26b7@lukather> (raw)
In-Reply-To: <20170418042205.27894-4-wens@csie.org>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote:
> The pinmux setting nodes all have an address element in their node
> names, however the pinctrl node does not have #address-cells.
>
> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi,
> dropping identifiers for functions that only have one possible setting,
> and using the pingroup name if the function is identically available on
> different pingroups.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Applied, and I really like the new names.
Would you make the same patch for everyone?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-04-18 9:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 4:22 [PATCH 0/3] ARM: sun8i: a83t: device tree cleanup Chen-Yu Tsai
2017-04-18 4:22 ` [PATCH 1/3] ARM: sun8i: a83t: Drop skeleton.dtsi Chen-Yu Tsai
2017-04-18 4:22 ` [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses Chen-Yu Tsai
2017-04-18 9:03 ` Maxime Ripard
2017-04-18 9:22 ` Chen-Yu Tsai
2017-04-19 6:53 ` Maxime Ripard
2017-04-18 4:22 ` [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names Chen-Yu Tsai
2017-04-18 9:04 ` Maxime Ripard [this message]
2017-04-18 9:16 ` Chen-Yu Tsai
2017-04-19 6:52 ` Maxime Ripard
2017-04-21 3:30 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418090447.dcxinewczubf26b7@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).