From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
John Stultz <john.stultz@linaro.org>,
Eric Dumazet <edumazet@google.com>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org, Arjan van de Ven <arjan@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Rik van Riel <riel@redhat.com>
Subject: [patch V2 01/10] timer: Invoke timer_start_debug() where it makes sense
Date: Tue, 18 Apr 2017 13:11:03 +0200 [thread overview]
Message-ID: <20170418111400.410779616@linutronix.de> (raw)
In-Reply-To: 20170418111102.490432548@linutronix.de
[-- Attachment #1: timer--call-debug-function-after-setting-properly-the-base-and-the-flags.patch --]
[-- Type: text/plain, Size: 834 bytes --]
The timer start debug function is called before the proper timer base
is set.
As a consequence the trace data contains the stale CPU and flags values.
Call the debug function after setting the new base and flags.
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/time/timer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -970,8 +970,6 @@ static inline int
if (!ret && pending_only)
goto out_unlock;
- debug_activate(timer, expires);
-
new_base = get_target_base(base, timer->flags);
if (base != new_base) {
@@ -994,6 +992,8 @@ static inline int
}
}
+ debug_activate(timer, expires);
+
/* Try to forward a stale timer base clock */
forward_timer_base(base);
next prev parent reply other threads:[~2017-04-18 16:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 11:11 [patch V2 00/10] timer: Move from a push remote at enqueue to a pull at expiry model Thomas Gleixner
2017-04-18 11:11 ` Thomas Gleixner [this message]
2017-04-18 11:11 ` [patch V2 02/10] timerqueue: Document return values of timerqueue_add/del() Thomas Gleixner
2017-04-18 11:11 ` [patch V2 03/10] timers: Rework idle logic Thomas Gleixner
2017-04-19 6:50 ` Peter Zijlstra
2017-04-21 14:43 ` Frederic Weisbecker
2017-04-18 11:11 ` [patch V2 04/10] timer: Keep the pinned timers separate from the others Thomas Gleixner
2017-04-18 11:11 ` [patch V2 05/10] timer: Retrieve next expiry of pinned/non-pinned timers seperately Thomas Gleixner
2017-04-19 7:05 ` Peter Zijlstra
2017-04-19 9:56 ` Thomas Gleixner
2017-04-18 11:11 ` [patch V2 06/10] timer: Restructure internal locking Thomas Gleixner
2017-04-19 7:07 ` Peter Zijlstra
2017-04-18 11:11 ` [patch V2 07/10] tick/sched: Split out jiffies update helper function Thomas Gleixner
2017-04-18 11:11 ` [patch V2 08/10] timer: Implement the hierarchical pull model Thomas Gleixner
2017-04-19 7:20 ` Peter Zijlstra
2017-04-19 7:24 ` Peter Zijlstra
2017-04-19 7:34 ` Peter Zijlstra
2017-04-19 7:38 ` Peter Zijlstra
2017-04-19 8:11 ` Peter Zijlstra
2017-04-19 8:31 ` Thomas Gleixner
2017-04-19 8:36 ` Peter Zijlstra
2017-04-19 9:03 ` Thomas Gleixner
2017-04-19 8:52 ` Peter Zijlstra
2017-04-19 9:09 ` Peter Zijlstra
2017-04-19 9:43 ` Thomas Gleixner
2017-04-19 9:52 ` Peter Zijlstra
2017-04-19 9:44 ` Peter Zijlstra
2017-04-19 9:53 ` Peter Zijlstra
2017-04-19 9:20 ` Peter Zijlstra
2017-04-19 10:22 ` Peter Zijlstra
2017-04-18 11:11 ` [patch V2 09/10] timer_migration: Add tracepoints Thomas Gleixner
2017-04-18 11:11 ` [patch V2 10/10] timer: Always queue timers on the local CPU Thomas Gleixner
2017-04-21 19:28 ` [patch V2 00/10] timer: Move from a push remote at enqueue to a pull at expiry model Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418111400.410779616@linutronix.de \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=arjan@infradead.org \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).