From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jakub Jedelsky <jakub.jedelsky@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: fix incorrect assignments
Date: Tue, 18 Apr 2017 13:52:01 +0200 [thread overview]
Message-ID: <20170418115201.GC17911@kroah.com> (raw)
In-Reply-To: <1491898748-20146-1-git-send-email-jakub.jedelsky@gmail.com>
On Tue, Apr 11, 2017 at 10:19:08AM +0200, Jakub Jedelsky wrote:
> Fixing warnings found by sparse on rtl8192u/ieee80211.
>
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1318:45: warning: incorrect type in assignment (different base types)
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1318:45: expected unsigned short [unsigned] [usertype] len
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1318:45: got restricted __be16 [usertype] <noident>
>
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1481:40: warning: incorrect type in assignment (different base types)
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1481:40: expected restricted __le16 <noident>
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1481:40: got int
>
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1483:40: warning: incorrect type in assignment (different base types)
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1483:40: expected restricted __le16 <noident>
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1483:40: got int
>
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1487:45: warning: incorrect type in assignment (different base types)
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1487:45: expected restricted __le16 <noident>
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1487:45: gotunsigned short [unsigned] [usertype] <noident>
>
> Signed-off-by: Jakub Jedelsky <jakub.jedelsky@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 2310ec7..7a31510 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -1315,7 +1315,7 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
> } else {
> u16 len;
> /* Leave Ethernet header part of hdr and full payload */
> - len = htons(sub_skb->len);
> + len = be16_to_cpu(htons(sub_skb->len));
> memcpy(skb_push(sub_skb, 2), &len, 2);
> memcpy(skb_push(sub_skb, ETH_ALEN), src, ETH_ALEN);
> memcpy(skb_push(sub_skb, ETH_ALEN), dst, ETH_ALEN);
> @@ -1478,13 +1478,15 @@ static int ieee80211_qos_convert_ac_to_parameters(struct
> /* WMM spec P.11: The minimum value for AIFSN shall be 2 */
> qos_param->aifs[aci] = (qos_param->aifs[aci] < 2) ? 2:qos_param->aifs[aci];
>
> - qos_param->cw_min[aci] = ac_params->ecw_min_max & 0x0F;
> + qos_param->cw_min[aci] =
> + cpu_to_le16(ac_params->ecw_min_max & 0x0F);
>
> - qos_param->cw_max[aci] = (ac_params->ecw_min_max & 0xF0) >> 4;
> + qos_param->cw_max[aci] =
> + cpu_to_le16((ac_params->ecw_min_max & 0xF0) >> 4);
>
> qos_param->flag[aci] =
> (ac_params->aci_aifsn & 0x10) ? 0x01 : 0x00;
> - qos_param->tx_op_limit[aci] = le16_to_cpu(ac_params->tx_op_limit);
> + qos_param->tx_op_limit[aci] = ac_params->tx_op_limit;
Are you sure about these changes? How did you test them?
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-18 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 8:19 [PATCH] staging: rtl8192u: fix incorrect assignments Jakub Jedelsky
2017-04-18 11:52 ` Greg Kroah-Hartman [this message]
2017-04-18 20:12 ` Jakub Jedelsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418115201.GC17911@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jakub.jedelsky@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).