From: Catalin Marinas <catalin.marinas@arm.com>
To: "dongbo (E)" <dongbo4@huawei.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
will.deacon@arm.com, Linuxarm <linuxarm@huawei.com>,
linux-arm-kernel@lists.infradead.org,
Peter Maydell <Peter.Maydell@arm.com>
Subject: Re: [PATCH] fs: Preventing READ_IMPLIES_EXEC Propagation
Date: Tue, 18 Apr 2017 18:01:18 +0100 [thread overview]
Message-ID: <20170418170118.GH27592@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <2414e3b3-03f6-bd6c-5aa4-ad58c66b5aa5@huawei.com>
On Thu, Apr 13, 2017 at 08:33:52PM +0800, dongbo (E) wrote:
> From: Dong Bo <dongbo4@huawei.com>
>
> In load_elf_binary(), once the READ_IMPLIES_EXEC flag is set,
> the flag is propagated to its child processes, even the elf
> files are marked as not requiring executable stack. It may
> cause superfluous operations on some arch, e.g.
> __sync_icache_dcache on aarch64 due to a PROT_READ mmap is
> also marked as PROT_EXEC.
>
> Signed-off-by: Dong Bo <dongbo4@huawei.com>
> ---
> fs/binfmt_elf.c | 2 ++
> fs/binfmt_elf_fdpic.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
> index 5075fd5..c52e670 100644
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -863,6 +863,8 @@ static int load_elf_binary(struct linux_binprm *bprm)
> SET_PERSONALITY2(loc->elf_ex, &arch_state);
> if (elf_read_implies_exec(loc->elf_ex, executable_stack))
> current->personality |= READ_IMPLIES_EXEC;
> + else
> + current->personality &= ~READ_IMPLIES_EXEC;
> if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)
> current->flags |= PF_RANDOMIZE;
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index cf93a4f..c4bc4d0 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -354,6 +354,8 @@ static int load_elf_fdpic_binary(struct linux_binprm *bprm)
> set_personality(PER_LINUX);
> if (elf_read_implies_exec(&exec_params.hdr, executable_stack))
> current->personality |= READ_IMPLIES_EXEC;
> + else
> + current->personality &= ~READ_IMPLIES_EXEC;
> setup_new_exec(bprm);
That's affecting most architectures with a risk of ABI breakage. We
could do it on arm64 only, though I'm not yet clear on the ABI
implications (at a first look, there shouldn't be any). This follows the
x86_64 approach but unfortunately we haven't done it on arm64 from the
start:
diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h
index 5d1700425efe..5941e7f6ae60 100644
--- a/arch/arm64/include/asm/elf.h
+++ b/arch/arm64/include/asm/elf.h
@@ -142,6 +142,7 @@ typedef struct user_fpsimd_state elf_fpregset_t;
({ \
clear_bit(TIF_32BIT, ¤t->mm->context.flags); \
clear_thread_flag(TIF_32BIT); \
+ current->personality &= ~READ_IMPLIES_EXEC; \
})
/* update AT_VECTOR_SIZE_ARCH if the number of NEW_AUX_ENT entries changes */
--
Catalin
next prev parent reply other threads:[~2017-04-18 17:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1492088223-98232-1-git-send-email-zhangshaokun@hisilicon.com>
2017-04-13 12:33 ` [PATCH] fs: Preventing READ_IMPLIES_EXEC Propagation dongbo (E)
2017-04-18 17:01 ` Catalin Marinas [this message]
2017-04-18 20:01 ` Peter Maydell
2017-04-19 10:33 ` Catalin Marinas
2017-04-19 10:45 ` Peter Maydell
2017-04-20 3:50 ` dongbo (E)
2017-04-24 15:40 ` Will Deacon
2017-04-24 15:58 ` Catalin Marinas
2017-04-24 16:05 ` Will Deacon
2017-04-24 16:14 ` Catalin Marinas
2017-04-25 7:04 ` dongbo (E)
2017-04-25 6:58 ` [PATCH REPOST] " dongbo (E)
2017-06-12 13:41 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418170118.GH27592@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=Peter.Maydell@arm.com \
--cc=dongbo4@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).