From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757391AbdDRSxp (ORCPT ); Tue, 18 Apr 2017 14:53:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56440 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755444AbdDRSxm (ORCPT ); Tue, 18 Apr 2017 14:53:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CE86480487 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CE86480487 Date: Tue, 18 Apr 2017 20:53:37 +0200 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode Message-ID: <20170418185337.GD15584@krava> References: <1491949266-6835-1-git-send-email-yao.jin@linux.intel.com> <1491949266-6835-5-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491949266-6835-5-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 18 Apr 2017 18:53:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 06:21:05AM +0800, Jin Yao wrote: SNIP > +static int hist_iter__branch_callback(struct hist_entry_iter *iter, > + struct addr_location *al __maybe_unused, > + bool single __maybe_unused, > + void *arg) > +{ > + struct hist_entry *he = iter->he; > + struct report *rep = arg; > + struct branch_info *bi; > + > + if (sort__mode == SORT_MODE__BRANCH) { is this check necessary? the hist_iter__branch_callback was set based on this check jirka