From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755444AbdDRVRf (ORCPT ); Tue, 18 Apr 2017 17:17:35 -0400 Received: from mail-bl2nam02on0073.outbound.protection.outlook.com ([104.47.38.73]:31712 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932738AbdDRVRL (ORCPT ); Tue, 18 Apr 2017 17:17:11 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; From: Tom Lendacky Subject: [PATCH v5 04/32] x86/CPU/AMD: Add the Secure Memory Encryption CPU feature To: , , , , , , , , , CC: Rik van Riel , Radim =?utf-8?b?S3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Larry Woodman , Brijesh Singh , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Alexander Potapenko , Dave Young , Thomas Gleixner , Dmitry Vyukov Date: Tue, 18 Apr 2017 16:17:00 -0500 Message-ID: <20170418211700.10190.2465.stgit@tlendack-t1.amdoffice.net> In-Reply-To: <20170418211612.10190.82788.stgit@tlendack-t1.amdoffice.net> References: <20170418211612.10190.82788.stgit@tlendack-t1.amdoffice.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR13CA0013.namprd13.prod.outlook.com (10.169.208.23) To MWHPR12MB1150.namprd12.prod.outlook.com (10.169.204.14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c029dd7d-eb9e-463b-1038-08d486a0440a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:MWHPR12MB1150; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;3:2dfFYe85C023ty/5PMbnMUblbp9+fc3NP5EwHZJTAP/vWZ8krN+KlXCCWZ7rSHWaIYkNhqEU4FnrZdOcsnq+L71XYXa+RVweG9snPd4TJq/WcMJQlVSGErqMOAE+PBcxfKS+pVDlRi08Kc7U7ib34ezLtznDRz0Wc0GBz1QmplHsrz8XvWzgrUCii1y74ybe89t/xC9eC/tC6eQXuDNgfp/wCGjVUjuzLnf3fGl5p48Y/KpsXNCi2jR8aLyhFoDokORPs55Lp22kl1KF928MT7+MM9rAcnhI6UtjWS5up+OjO7db6/AtdlhogYJre5IMZuvH6rkmo4kojcJO23HXOPLSYThZ0Tk8hCFzRFfCU8U=;25:O0RMGA2vS7rpbjcX9qimh7CHLqQNg4lRy4UvFX6AWY3MAUZNfg5dDuwpJ0YluMUcBBGQ/j9B1I+cOvQHqgUhpaJLmJbLY1eQq8uORvIUoX7vw8KVSMOV6aofH4ETkAuh4ISTXcSoXnAG7Cc6M++XUz7Of1tjWm0tbPxwA9K61UIt8rNJo4MW5t1f4A0s95HC8756j2QJ6R/RdGtddnUWfzE17nCfPwzDKHHf4N6z3Ur35xErsJZdHnoPzy6z0qiEH3znNQPO6v3dwTaZv8mReCF9vAIS/l/rqSoDmoAkmwhf6KfHm1f8AotckWFVi53x90KIEKleTotS+RpYPXeIo5bC6CqGjN1q93P8oI16lsszjLkwaJ9AQV3MibaI/vY1NIjNOAJVk3qwL4AOQZYNsNkgY3RQ6HXX8YN2mpNp+Q3oSOUVDj8sBRHBivubjGKCZVLDoRMzUM9dKqCqqU/E1w== X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;31:K6mH6y0tK3DFp2mXGvZsgd5Gz98vG627ro5McPykb+420ZFarabHmMf9oH7snQQ4B3OIQo23Cy/I0aMVv7W1r4jeEBFVjtJpBbt056agq4Y4YMaOZWSl/mpSMWX0CIDChrq6FnkGBdloALdZViNWPX41PgmDP/xNuCqFQVXq/ALExzSijCrSwnZsotvh7liqRywGvmlHh9h2t6PRK3pOaoF4aqqbBswXpMSVPOIceCU=;20:4Z6ZcXBMpkSiP417LiREjd7wc/yMps9U11NNB+OAJ54MULaj1IPV+/pCRNHLoqdCaX9SWjm94tzsMOj46IHGsGMP0CwMPLOe0dqRgOZE6x4GBoxed0YzrtP6RZjAohkB4v659K1hHJukhoUezzH6ykErvmIgFPkhQNq1t73CpaIDnF9fSyju5JA68ACF333NRQ8b3AU+dPH8i+OTW7e+eXFhFZ607VvqbSngj01L073FSWSQbOtpKGLm+DLa8rj6Kyzb05Sj2feX2hqbcOcG2x0Df9On/FFr46W0wzB+95Fgsp2C6tKumirS3LUJzDDyEItaLRb2qMrCYcX5c1OwlmURnkylvAHnByy4Dn9TEtbWFEqiBkTm6W61Zq3aluJ1bcAMqnqW1kzCGm0xwI8ejCyMfRFAhdvihvCBkF3LAGtNuOO+tggtjgfaG/Jh20vCY0iiCS6fuYqQ5TA7E3SM8gl8tpn4IYkhu5i5Wows/7YX/nihxQBVFbFjIBZC326G X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148);SRVR:MWHPR12MB1150;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1150; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;4:6gX4X4HnuKV2H0mWGrrpV7lAH9U6hORvM1ub4hYwsErTNjH9wRveIgTAgn+Fou890E0P4ff1WixyXqXa/ZNjKoOpVeDk8BRBn/Ut3wIfQ3Kz90E6cw35utEUBJNg8JzSQmZZpahyPQTngbafbkC5fE0SodR5W/QfFpGoeM30xlQGBdicQf1Li+8d+pBeVtKsuxaB3GZerMhGXqhc8OzadMTDuMpFdodRqwex82qiRztuDNMyq2Ugy008tDjNEh18DtJSHwmBoeB57kT/3AP+/OvktcbWcNrhXp7i58W4583XRhzBhBNz3ktl8hCeEi9A5oh4dwXmCeIlUTd7jNp1g7ZvTYkiNUtKDkWKKJD9MRmN0v00vF7j/IMQIT9gOzvU7yg0jCCshuRhYNGEvB7XL3xu3IQLvJ/Aj+cQWNyzyJ+RxlksyeBDjtfW0c3WuQeolgKcael/9PLQ8hzcFF1jLh3PeXlYCnZ+uX6lV62V+qAh8iuSE297QJ+n18Ct5UoAAC24YEMRwBwnF1PMt06ZTRMO+6M8nksZMgkU4x/6nte/duXKgAzpKd/ByT9iBn4gSnvGoTTqHPJpsGEuUTtbJwzyduUsnDUOn/vZr/qBTauUbAmoytrHyrUPX0bQ8DBB4p/2rui09GMHeAMBIDPs18SHUUuXLDICgaybQn9+pYDicvdiEddPaiSI3sJP0BWN53QGpNmCGgwgTHUecmIz9iSoz7OzAexuTbg9o6gPF3LGeFCYgx3bSlBDn3I8rtV5i5pSkA0BKjsD9OqO09ODBOpaSDW4v2RTqZsIIiqFGuE1CrIs5pAfmy25kVvojb4z X-Forefront-PRVS: 028166BF91 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39450400003)(39860400002)(39840400002)(39400400002)(39850400002)(39410400002)(50466002)(5660300001)(103116003)(305945005)(97746001)(189998001)(53416004)(33646002)(7736002)(81166006)(54906002)(76176999)(2950100002)(8676002)(54356999)(55016002)(7416002)(50986999)(23676002)(42186005)(6666003)(6506006)(7406005)(1076002)(83506001)(230700001)(86362001)(38730400002)(4326008)(9686003)(47776003)(66066001)(25786009)(53936002)(2201001)(4001350100001)(3846002)(2906002)(6116002)(71626007)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1150;H:tlendack-t1.amdoffice.net;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUwOzIzOmt1RHJEUE5ic2RBVkJyUUhPNEtSckFtRE1P?= =?utf-8?B?RjN6aGV6alh1aEluKzBpcEY3VUc4Q3kxZXhNQk9UVXNsbFY2Z05xdk5SQng4?= =?utf-8?B?bzNKa1B6cFhtdlJHTlVzb2lCMTBVRGxkSVEvR3ZmNm9Gd1FiMW1IbnNnVU4x?= =?utf-8?B?VU5JcjVUMkNmVitYSXN3dWJwakNFWlpRM2x2YkR4OVJnZWplNFJLN2k0OE0z?= =?utf-8?B?L01RTU1wdm5lSVNFcHNwb2dhK1BVYkl1bjdJYkxjVHZORkhISFhuZDFvOEsw?= =?utf-8?B?d2xWWnJta2toeHZhYjI2aXEvendjNlErTXpHQXkrSGY3ZGdzb1pDTVkxSHMx?= =?utf-8?B?bEIvTzJMbUVNcWsvWDlsR3B6bU5BenRWakFQeUVTdUZRRkRHTkFnNzcxZjh0?= =?utf-8?B?Q0pCQVk2OHQ1Ry9xVnZRWnVVb0pjWHcvb1YrTlI2WFM2b1R3Q3dVYVpoOXRN?= =?utf-8?B?M2NtSTFXNEhWbGJkY0hWTE1ZU2VXdnFiVEkvZGJNaHpDZlMrUlMrR3YzT21u?= =?utf-8?B?eVErRUt1bHBEUEliY3g2VFM1VUFPcjREMjJVcFg2MjV3cFVzRmxlaHlsQS9s?= =?utf-8?B?MWlUMW9wYzB5L3ZTZ1FmMXRVckhld1pWYWs2c1d6emVLeDYraFNSZ3dHR0FH?= =?utf-8?B?T2VvNUNBWW1LUG4zVjhHamZqRGs2OFFSQUNFNEw0anlxazBwZGNqakJMMjRi?= =?utf-8?B?TFJGK1BxY0JhcWxrSkJTNzZQZStJUnhVcnFPb3BnbmthbnJLdFFlQWI1TzhO?= =?utf-8?B?VThseGJOazh5UDhSejdwVC9vZXE3ZHZrYjNTaDdkejVkWTBNeWZVYUIrSVVU?= =?utf-8?B?eHM5MVVWSmRRME4vUTVjSlJCNGVPSlA0RDNDTHhOUUMwMDdWLzhCYzFpejZK?= =?utf-8?B?MFhXd3V4QXlZMTczMm44T2s2Vi92ZzZ4OEc0TlhFVFozRHhtRHE1Q2dqbXBJ?= =?utf-8?B?UFRuOGFYaVVnQUZmMy9hUFJzTWwvWG0vL3VTMWZmMVJybTJwalluTmRpalpq?= =?utf-8?B?dnNqWlB1QXlUMzBBbTdYUE1tSUtYNWFmWm1HZC9IcTd3eVkrTzJFdTc0Z2hN?= =?utf-8?B?dkNvYk0zaWNSaVJXS1JjQzNEc0ViQ04wejF0dVA4cVZ2OC9OcEdVak1lTEUy?= =?utf-8?B?R3N4ZlBzd2dOVzM3VjRHcnl6d2QwY3FrNmU5aUVjT2VlUnR4YWpjeDAvbVhT?= =?utf-8?B?dWdmWTVtUVMvUkY3MENpdlY0c1V2Wnlqb3VuN2Jpd1RIWkJhRTVSeXc1dml4?= =?utf-8?B?dVNxbGxSL2JacUh6RHpXWGFXdDJxZnVSaFRuSnBuV0tuczB3MGxNWllwakxK?= =?utf-8?B?OEp1RlBCSk5ua21XaE9EY1ROczdoaVF0YWFiL0pKYmJzY2l0T0kwSy92S2VY?= =?utf-8?B?YTRvMXFmL2lFWWwvTk82YmtPTi9xTUtnZzY0Y2VqWitld3VSZm9TVGN4d3Zo?= =?utf-8?B?KzJET3VGUjBlOGtoZkI3MmZGeU9ZdDNMd2hLZHU4WEVtY09sdGpzWjJaS093?= =?utf-8?B?K3dQYVovWWdpUVJYNUNWRVFvRmtqQk1hVVlrUjl4VmV4ZzUrNy9GaWhBaUtL?= =?utf-8?B?azdZU3Z2bGQvVTdLQm5UNHN0SnVjZG4xL0FlSFI1NGk4UXlZWVpoUE9rODBZ?= =?utf-8?B?OEpkMlBmRFF3d1kzRytBalVLY2thS2NNZHJjZzQwMnNpb0JJalVCSkVBPT0=?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;6:2ImuOvpKVY2spo50BOBy62CTmhFsMnUfSmELrxcK6eoUDOOeHgCZXFGfpiD+6DtpTtffsOhkZ/u7CSpWbghmMQWWSQUQ+5O1Jx8OEymlKvACKEnTyltkS2j9q8XNS9DPCm98ng80Y0dpDOaB/M3dyHZbCTtTN6/uc99Ta4CFTQr6SkV66a3+zCY8PMWuckvFWD62ggyVy7G22lGvjnWiLPio/TzCNLiGUY0H9+dFejHIO/vfWTAWmAIFxtEGLmzrStb8IcFSw32vnuUWQ6E3VNmGiYHvF10g/IZ5txcert8IvlNUQeYhcGLLN7aa+VSpSR8cLoI8cEckMV9puJiBwupXXv7GFdDL6SHneLNH1pW+Sd6bFFzzwNkqZM30EYyssKXNNNfN/TYvfsanyjVMJnordEh0XFVw1q392dELZ7jaT9oYR4HgWoRmuxFImTm3ksO3mmIphWYk9/uzXyZiBg09haHbC0ifZMM+wAbnino=;5:WzVbAapYpl5fhLSGuQcO7UNWvcAYvmfFiAuxAjMB2wasOMCpG3INoyduhFT6DLM50twAmB4/dMIbuUAyuwXyKfSVre4Rk4ic4GJsPOKxCAV/kOdhCc4bl3Hke4XkXsqMCCRI2jDOYDZDKs5P/GBfeQ==;24:lIahqwRaoi51LzQbO/6IhJyI4Cr0PkOIOA3IULk8/ijHICLe5YQmgPPp3QD4Lw3NfOxGPNxPGj1AqMZZESFKnHaaFydKWIZ8/hhMWsyvz3k= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1150;7:PUMKQgJiJKiVWu94wF4HlOfEZYxj/vNj0DaOhNC53UMrc0aGwlMIsvrwTq7nuc5PQf76E1RNRSBwR0LeukEZ3AVbze3s1aqlQfSv/1UqlgLPOkD00xcICm+7UP46D6LNCZoRsJGIVvyvoIb5E5bqT7JwTjCogfL3OGMIkRkppXrfGuHVXJy+lK/INa2chDFIcbbfIdk8Pqjw+gL4K5kr999io4qt1cTTixciTpoL3IrN9jRCBsYo1BywpYzL6zwpozkyyzqk/dbmCBne4rmlY3br17jafT5Lvpa8Tf2FN+PryfgeyKMkOvI3l+P453UOhlxTh6jBA50XXDu2NijshQ==;20:QZoT9CmFs/D6+pq5yMKJ39pfoccOl82DTbUcJsIwCoRqmwGeqhU2tEHNyGnADOhf1eivdL56D4QufxFPE7G4bqsvEtodOCCKTWEJx92FFjYhTAkz7GXZbtIhUDJK4rtJCdAZDhKP8V3tLJGnCEqyIwbhYxYArHnjhh4/y+ObRYrocTxJQ2ilIKAxf2FEZoZoH/m5utWxdzY6GWbMMDE5ui/E24+sl/DywvJ9Sw8hNeV6cEm8H6AhvSc/elF6o7Pu X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2017 21:17:04.2126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1150 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Update the CPU features to include identifying and reporting on the Secure Memory Encryption (SME) feature. SME is identified by CPUID 0x8000001f, but requires BIOS support to enable it (set bit 23 of MSR_K8_SYSCFG). Only show the SME feature as available if reported by CPUID and enabled by BIOS. Signed-off-by: Tom Lendacky --- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/msr-index.h | 2 ++ arch/x86/kernel/cpu/amd.c | 15 +++++++++++++++ arch/x86/kernel/cpu/scattered.c | 1 + 4 files changed, 19 insertions(+) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index 2701e5f..2b692df 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -196,6 +196,7 @@ #define X86_FEATURE_HW_PSTATE ( 7*32+ 8) /* AMD HW-PState */ #define X86_FEATURE_PROC_FEEDBACK ( 7*32+ 9) /* AMD ProcFeedbackInterface */ +#define X86_FEATURE_SME ( 7*32+10) /* AMD Secure Memory Encryption */ #define X86_FEATURE_INTEL_PPIN ( 7*32+14) /* Intel Processor Inventory Number */ #define X86_FEATURE_INTEL_PT ( 7*32+15) /* Intel Processor Trace */ diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index 673f9ac..8ff4aaa 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -350,6 +350,8 @@ #define MSR_K8_TOP_MEM1 0xc001001a #define MSR_K8_TOP_MEM2 0xc001001d #define MSR_K8_SYSCFG 0xc0010010 +#define MSR_K8_SYSCFG_MEM_ENCRYPT_BIT 23 +#define MSR_K8_SYSCFG_MEM_ENCRYPT BIT_ULL(MSR_K8_SYSCFG_MEM_ENCRYPT_BIT) #define MSR_K8_INT_PENDING_MSG 0xc0010055 /* C1E active bits in int pending message */ #define K8_INTP_C1E_ACTIVE_MASK 0x18000000 diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index c36140d..5fc5232 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -611,6 +611,21 @@ static void early_init_amd(struct cpuinfo_x86 *c) */ if (cpu_has_amd_erratum(c, amd_erratum_400)) set_cpu_bug(c, X86_BUG_AMD_E400); + + /* + * BIOS support is required for SME. If BIOS has not enabled SME + * then don't advertise the feature (set in scattered.c) + */ + if (c->extended_cpuid_level >= 0x8000001f) { + if (cpu_has(c, X86_FEATURE_SME)) { + u64 msr; + + /* Check if SME is enabled */ + rdmsrl(MSR_K8_SYSCFG, msr); + if (!(msr & MSR_K8_SYSCFG_MEM_ENCRYPT)) + clear_cpu_cap(c, X86_FEATURE_SME); + } + } } static void init_amd_k8(struct cpuinfo_x86 *c) diff --git a/arch/x86/kernel/cpu/scattered.c b/arch/x86/kernel/cpu/scattered.c index 23c2350..05459ad 100644 --- a/arch/x86/kernel/cpu/scattered.c +++ b/arch/x86/kernel/cpu/scattered.c @@ -31,6 +31,7 @@ struct cpuid_bit { { X86_FEATURE_HW_PSTATE, CPUID_EDX, 7, 0x80000007, 0 }, { X86_FEATURE_CPB, CPUID_EDX, 9, 0x80000007, 0 }, { X86_FEATURE_PROC_FEEDBACK, CPUID_EDX, 11, 0x80000007, 0 }, + { X86_FEATURE_SME, CPUID_EAX, 0, 0x8000001f, 0 }, { 0, 0, 0, 0, 0 } };