linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes
Date: Wed, 19 Apr 2017 01:24:31 +0200	[thread overview]
Message-ID: <20170418232431.GB13724@zurbaran.ger.intel.com> (raw)
In-Reply-To: <20170418100916.GB2823@localhost>

Hi Johan,

On Tue, Apr 18, 2017 at 12:09:16PM +0200, Johan Hovold wrote:
> On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote:
> > This started out with the observation that the nfcmrvl_uart driver
> > unconditionally dereferenced the tty class device despite the fact that
> > not every tty has an associated struct device (Unix98 ptys). Some
> > further changes were needed in the common nfcmrvl code to fully address
> > this, some of which also incidentally fixed a few related bugs (e.g.
> > resource leaks in error paths).
> > 
> > While fixing this I stumbled over a regression in NFC core that lead to
> > broken registration error paths and misnamed workqueues.
> > 
> > Note that this has only been tested by configuring the n_hci line
> > discipline for different ttys without any actual NFC hardware connected.
> 
> > Johan Hovold (8):
> >   NFC: fix broken device allocation
> >   NFC: nfcmrvl_uart: add missing tty-device sanity check
> >   NFC: nfcmrvl: do not use device-managed resources
> >   NFC: nfcmrvl: use nfc-device for firmware download
> >   NFC: nfcmrvl: fix firmware-management initialisation
> >   NFC: nfcmrvl_uart: fix device-node leak during probe
> >   NFC: nfcmrvl_usb: use interface as phy device
> >   NFC: nfcmrvl: allow gpio 0 for reset signalling
> 
> Any chance of getting these into 4.12, Samuel?
I have yours and Mark Greer patchset pending. I'll push them to nfc-next
and see if I can send another pull request to Dave by the end of this
week.

Cheers,
Samuel.

  reply	other threads:[~2017-04-18 23:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 10:15 [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes Johan Hovold
2017-03-30 10:15 ` [PATCH v2 1/8] NFC: fix broken device allocation Johan Hovold
2017-03-30 10:15 ` [PATCH v2 2/8] NFC: nfcmrvl_uart: add missing tty-device sanity check Johan Hovold
2017-03-30 10:15 ` [PATCH v2 3/8] NFC: nfcmrvl: do not use device-managed resources Johan Hovold
2017-03-30 10:15 ` [PATCH v2 4/8] NFC: nfcmrvl: use nfc-device for firmware download Johan Hovold
2017-03-30 10:15 ` [PATCH v2 5/8] NFC: nfcmrvl: fix firmware-management initialisation Johan Hovold
2017-03-30 10:15 ` [PATCH v2 6/8] NFC: nfcmrvl_uart: fix device-node leak during probe Johan Hovold
2017-03-30 10:15 ` [PATCH v2 7/8] NFC: nfcmrvl_usb: use interface as phy device Johan Hovold
2017-03-30 10:15 ` [PATCH v2 8/8] NFC: nfcmrvl: allow gpio 0 for reset signalling Johan Hovold
2017-04-18 10:09 ` [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes Johan Hovold
2017-04-18 23:24   ` Samuel Ortiz [this message]
2017-04-26 10:36     ` Johan Hovold
2017-04-26 22:42 ` Samuel Ortiz
2017-05-16  9:42   ` Johan Hovold
2017-06-01  7:55     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418232431.GB13724@zurbaran.ger.intel.com \
    --to=sameo@linux.intel.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).