linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: Logan Gunthorpe <logang@deltatee.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvmet: convert from kmap to nvmet_copy_from_sgl
Date: Wed, 19 Apr 2017 11:38:26 +0200	[thread overview]
Message-ID: <20170419093826.GB10632@linux-x5ow.site> (raw)
In-Reply-To: <3cf1fbf9-8b1d-4acb-e680-87efa5ca7c6d@mellanox.com>

On Wed, Apr 19, 2017 at 12:33:09PM +0300, Max Gurtovoy wrote:
> Hi Logan,
> 
> On 4/19/2017 2:32 AM, Logan Gunthorpe wrote:
> >This is safer as it doesn't rely on the data being stored in
> >a single page in an sgl.
> >
> >It also aids our effort to start phasing out users of sg_page. See [1].
> >
> >For this we kmalloc some memory, copy to it and free at the end. Note:
> >we can't allocate this memory on the stack as the kbuild test robot
> >reports some frame size overflows on i386.
> >
> >[1] https://lwn.net/Articles/720053/
> >
> >Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> >Cc: Christoph Hellwig <hch@lst.de>
> >Cc: Sagi Grimberg <sagi@grimberg.me>
> >---
> > drivers/nvme/target/fabrics-cmd.c | 32 +++++++++++++++++++++++++-------
> > 1 file changed, 25 insertions(+), 7 deletions(-)
> >
> >diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c
> >index 8bd022af..2e0ab10 100644
> >--- a/drivers/nvme/target/fabrics-cmd.c
> >+++ b/drivers/nvme/target/fabrics-cmd.c
> >@@ -122,7 +122,15 @@ static void nvmet_execute_admin_connect(struct nvmet_req *req)
> > 	struct nvmet_ctrl *ctrl = NULL;
> > 	u16 status = 0;
> >
> >-	d = kmap(sg_page(req->sg)) + req->sg->offset;
> >+	d = kmalloc(sizeof(*d), GFP_KERNEL);
> 
> I'd prefer removing the dynamic allocation and use d on the stack to
> simplify the code.
> Any thoughts ?

Hi Max, 

Pasting from above:

> >we can't allocate this memory on the stack as the kbuild test robot
> >reports some frame size overflows on i386.


-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

  reply	other threads:[~2017-04-19  9:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 23:32 Logan Gunthorpe
2017-04-19  9:33 ` Max Gurtovoy
2017-04-19  9:38   ` Johannes Thumshirn [this message]
2017-04-19  9:44     ` Max Gurtovoy
2017-04-19 15:40       ` Logan Gunthorpe
2017-04-19 19:32 ` Christoph Hellwig
2017-04-20 11:31 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419093826.GB10632@linux-x5ow.site \
    --to=jthumshirn@suse.de \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=logang@deltatee.com \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    --subject='Re: [PATCH] nvmet: convert from kmap to nvmet_copy_from_sgl' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).